Fix: If versionsToShow is not an array, return N/A #975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hey! Thanks for this PR. There seems to be a mismatch between your Prettier version and what we use here. Could you please run |
thymikee
requested changes
Feb 14, 2020
| const versionsToShow = versions.join(', '); | ||
| const versionsToShow = Array.isArray(versions) | ||
| ? versions.join(', ') | ||
| : 'N/A'; |
Member
There was a problem hiding this comment.
Please update the HealthCheckResult types to account for this type, so we can avoid similar issues in the future
Contributor
Author
There was a problem hiding this comment.
Hey @thymikee, thanks very much for the pointers, I have made the changes :) Thanks!
…an array of strings or a string
lucasbento
approved these changes
Feb 16, 2020
thymikee
pushed a commit
that referenced
this pull request
Feb 17, 2020
* If versionsToShow is not an array, return N/A * If versionsToShow is not an array, return N/A * ran yarn lint --fix * updated HealthCheckResult types to account for versions being either an array of strings or a string * deleted unneeded history file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
I tried using the
doctorcommand in my machine but it crashed like this:Turned out to be a problem with Android SDK not being identified and throwing an error because it returns
versionsin theandroidSDK.ts