-
Notifications
You must be signed in to change notification settings - Fork 929
fix(ios): skip script phases on abstract targets #982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Going to wait for one more review before moving forward. Thanks for sending over the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, this looks good to me 👍
* fix(ios): skip script phases on abstract targets Fixes invertase/react-native-firebase#2800 * fix typo * update tests
@Salakar @thymikee hello, what about real targets inside abstract targets ? Pls also check link above.
|
Summary:
Abstract targets don't support script phases, this change skips adding script phases if the current target is abstract.
Fixes invertase/react-native-firebase#2800
cc @orta / @alloy for review please, thanks!
Test Plan:
@gabrielbull would you be able to patch package this change in and confirm it now works? invertase/react-native-firebase#2800
script phases continue to work on non abstract targets:
