[iOS] Expose isAccessibilityElement as a prop#3115
Merged
rborn merged 2 commits intoreact-native-maps:masterfrom Oct 10, 2019
Merged
[iOS] Expose isAccessibilityElement as a prop#3115rborn merged 2 commits intoreact-native-maps:masterfrom
rborn merged 2 commits intoreact-native-maps:masterfrom
Conversation
Collaborator
|
This looks great, any chance to do it for android too (if it's not there already) ? 😻 |
Contributor
Author
|
Makes sense, I can do that. The reason I didn't do that here is that Android does not exhibit the same issues as iOS -- when TalkBack is on, markers are still tappable. But I agree exposing the prop cross-platform is the right move. |
Contributor
Author
|
although hm -- |
Collaborator
|
Ok, in this case can we document the new property and mention is iOs only? |
Collaborator
Contributor
Author
|
Sounds good -- will do. |
Collaborator
yuheidapperapps
added a commit
to yuheidapperapps/react-native-maps
that referenced
this pull request
Oct 15, 2019
* master: (31 commits) Wider Note column (prevent horisontal scroll) (react-native-maps#3130) replaced deprecated bridge.imageLoader calls with moduleForClass API (react-native-maps#3125) Implement onUserLocationChange in AIRMap (react-native-maps#2889) keep current mapType when taking snapshot (react-native-maps#3120) Add mapPadding on iOS maps (react-native-maps#3119) [iOS] Expose isAccessibilityElement as a prop (react-native-maps#3115) Add supportLibVersion safeguard in gradle build (react-native-maps#3106) [0.26.1] Release rn 0.60.5 support (react-native-maps#3020) "AIRMap" was not found in the UIManager IN "0.26.0" (react-native-maps#3103) [0.26.0] Release Add Heatmap back in (react-native-maps#3064) Fixes NPE while removing already removed marker. (react-native-maps#3032) Add flat property binding on Marker for iOS (react-native-maps#3051) Add heading to the onUserLocationChange listener (react-native-maps#3045) Add onDoublePress callback (react-native-maps#2937) Allow using onPanDrag while scrollEnabled=true (react-native-maps#2935) updating pods for compile error (react-native-maps#3011) add overlay onPress event (react-native-maps#3007) Fix playServicesVersion name in installation docs (react-native-maps#3016) ...
pinpong
pushed a commit
to pinpong/react-native-maps
that referenced
this pull request
Feb 28, 2025
* [iOS] Expose isAccessibilityElement as a prop * Set default isAccessibilityElement to NO, update readme
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does any other open PR do the same thing?
No
What issue is this PR fixing?
#3114
When the MapView has
isAccessibilityElement: YES, the map captures any accessibility taps and does not forward them on to the markers. Passing anisAccessibilityElementprop allows the developer to expose map children (ie markers) to VoiceOver and/or other accessibility tools.How did you test this PR?
isAccessibilityElement: falseon map.