Skip to content

Implement mapPadding in iOS maps#3119

Merged
rborn merged 1 commit intoreact-native-maps:masterfrom
ssztemberg:feature/ios-mappadding
Oct 11, 2019
Merged

Implement mapPadding in iOS maps#3119
rborn merged 1 commit intoreact-native-maps:masterfrom
ssztemberg:feature/ios-mappadding

Conversation

@ssztemberg
Copy link
Copy Markdown
Contributor

Does any other open PR do the same thing?

No

What issue is this PR fixing?

During my migration to Apple Maps, I noticed that mapPadding isn't supported. This PR fixes that.

How did you test this PR?

  • Create a plain MapView
  • Add some children to MapView
  • Add mapPadding
  • Padding should work just fine, just like on Google Maps

@rborn rborn merged commit 1abcd6a into react-native-maps:master Oct 11, 2019
yuheidapperapps added a commit to yuheidapperapps/react-native-maps that referenced this pull request Oct 15, 2019
* master: (31 commits)
  Wider Note column (prevent horisontal scroll) (react-native-maps#3130)
  replaced deprecated bridge.imageLoader calls with moduleForClass API (react-native-maps#3125)
  Implement onUserLocationChange in AIRMap (react-native-maps#2889)
  keep current mapType when taking snapshot (react-native-maps#3120)
  Add mapPadding on iOS maps (react-native-maps#3119)
  [iOS] Expose isAccessibilityElement as a prop (react-native-maps#3115)
  Add supportLibVersion safeguard in gradle build (react-native-maps#3106)
  [0.26.1] Release
  rn 0.60.5 support (react-native-maps#3020)
  "AIRMap" was not found in the UIManager IN "0.26.0" (react-native-maps#3103)
  [0.26.0] Release
  Add Heatmap back in (react-native-maps#3064)
  Fixes NPE while removing already removed marker. (react-native-maps#3032)
  Add flat property binding on Marker for iOS (react-native-maps#3051)
  Add heading to the onUserLocationChange listener (react-native-maps#3045)
  Add onDoublePress callback (react-native-maps#2937)
  Allow using onPanDrag while scrollEnabled=true (react-native-maps#2935)
  updating pods for compile error (react-native-maps#3011)
  add overlay onPress event (react-native-maps#3007)
  Fix playServicesVersion name in installation docs (react-native-maps#3016)
  ...
pinpong pushed a commit to pinpong/react-native-maps that referenced this pull request Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants