Add override props #714
Merged
Add override props #714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I cannot test on windows so I'll believe this is a right thing to have 🤷 🙂 thank you! |
vonovak
pushed a commit
that referenced
this pull request
Jan 23, 2023
## [6.7.3](v6.7.2...v6.7.3) (2023-01-23) ### Bug Fixes * **windows:** unable to override WindowsTargetVersion ([#714](#714)) ([5ad973c](5ad973c))
Member
|
🎉 This issue has been resolved in version 6.7.3 🎉 If this package helps you, consider sponsoring us! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
On windows 11, DateTimePicker vcxproj defaults the WindowsTargetVersion to 10.0.18382 if no WindowsTargetVersion is specified. We are not able override it with a particular WindowsTargetVersion we are currently using in the parent project (where we use the DateTimePicker as a npm dependency).
This PR solves #713
Compatibility
Checklist
README.mdexample/App.js)