Fix the ReduxExample app (3)#1144
Merged
grabbou merged 5 commits intoreact-navigation:masterfrom Apr 23, 2017
Merged
Conversation
grabbou
approved these changes
Apr 22, 2017
|
I agree it would be great to have some sort of a check to make sure Redux example also works. Thanks for keeping an eye on it! |
cooperka
force-pushed
the
fix-redux-example-3
branch
from
2f2dd1f to
ae2af8d
Compare
This was referenced Apr 22, 2017
Merged
sourcecode911
pushed a commit
to sourcecode911/react-navigation
that referenced
this pull request
Mar 9, 2020
* [Example] Upgrade dependencies to fix the ReduxExample app * [Example] Also upgrade and fix the LinkingExample app * [Example] Update MainApplication.java to fix Android API
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simply upgrades dependencies to fix the ReduxExample and LinkingExample apps. The react-native versions were out of sync, causing the errors described in #550 (
Expected array with count X, but count is Y).Perhaps we should add example app testing to the CI to prevent these apps from continually breaking? I'm not familiar with CircleCI but I'd be happy to try if nobody has objections.
Fixes #550.