Peer dependencies of eslint-config-react-app should probably be regular dependencies

[kirill-konshin]

If user wants only the config and nothing else the one should still install all the deps, which can be done automatically and with no hassle.

Currently, I have to install eslint-plugin-flowtype which I am not even using in my project...

Moreover, version of babel-eslint is outdated (available: 10, listed: 9).

As one of the solutions, maybe, we can create one extra package in this repo and name it like eslint-config-react-app-pack, which will have all the needed deps?

[mrmckeb]

Hi @kirill-konshin, I understand what you're saying, and in a way I agree with you - but I also think there are a lot of strengths in the peer-dependency approach. For one, it helps to eliminate issues where multiple versions of the same dependency are installed - which can cause problems.

The obvious problem with peer dependencies, which I've faced too, is that they can be outdated at times and even if the new version is compatible, you keep seeing errors upon install (which is annoying). The other issue which you've raised above is the optional dependency issue - this isn't supported by npm.

Perhaps the better approach is for us to publish a base config, and then a flow config that extends the base config - then you won't hit this issue.

What are your thoughts on that?

[kirill-konshin]

I agree, it does makes sense to divide packages (or configs) into a more granular set.

[stale]

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

[kirill-konshin]

Anti-stale-bot-ping )

[stale]

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

[kirill-konshin]

Anti stale bot ping

[skoestler]

I have a project that is just a component library so I'm not using create-react-app but I wanted the tooling to be consistent with our CRA projects so using babel-preset-react-app and eslint-config-react-app is a great option (I really appreciate that they are published as they are).

I did find it odd that babel-preset-react-app includes all of the plugins as dependencies and eslint-config-react-app uses peer dependencies.

I admit that I could totally be missing the reason for why they are different, but in my case this change would be helpful.