Skip to content

fix: Use mandatory file extensions#11650

Open
modernizer-bot wants to merge 1 commit into
react:mainfrom
modernizer-bot:explicit-path-5
Open

fix: Use mandatory file extensions#11650
modernizer-bot wants to merge 1 commit into
react:mainfrom
modernizer-bot:explicit-path-5

Conversation

@modernizer-bot
Copy link
Copy Markdown

A file extension must be provided when using the import keyword to resolve relative or absolute specifiers. Directory indexes (e.g. './startup/index.js') must also be fully specified.

This behavior matches how import behaves in browser environments, assuming a typically configured server.

Ref: https://nodejs.org/docs/latest-v17.x/api/esm.html#mandatory-file-extensions

(Even if you perhaps using require() and extension-less paths, using extension can help with the migration to esm later)


Hi, I'm experimenting with a github bot to do quality checks and sending automated pr that could improve your code.
Sorry if I'm not helpful.

@facebook-github-bot
Copy link
Copy Markdown

Hi @modernizer-bot!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@stale
Copy link
Copy Markdown

stale Bot commented Jan 8, 2022

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale Bot added the stale label Jan 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants