fix: add iframe title to react error overlay#12038
Conversation
|
Hi @jamidwyer! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
| // We need to schedule the first render. | ||
| isLoadingIframe = true; | ||
| const loadingIframe = window.document.createElement('iframe'); | ||
| loadingIframe.setAttribute('title', 'React Error Overlay'); |
There was a problem hiding this comment.
the only non-prettier change i made. :)
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
2 participants
Hello! I added @axe-core/react to check accessibility on a project, and one of the errors I saw was an iframe with no "title" attribute. It appears to be coming from the react-error-overlay. This pull request adds a title.
The only verification I did was run
npm testand it passed.Thank you!