[LEOP-317]Fix not find encodebase64 function error#12112
Open
salleyliu wants to merge 29 commits into
Open
Conversation
* Backpackify * add cache-loader to speed up local development * add cache-loader to speed up local development * restore link style of paths.js and webpack.config.js in react-scripts * restore link style of paths.js and webpack.config.js in react-scripts again * restore link style of paths.js and webpack.config.js in react-scripts again 2x * restore link style of paths.js and webpack.config.js in react-scripts again 3x * restore link style of paths.js and webpack.config.js in react-scripts again 4x * restore link style of paths.js and webpack.config.js in react-scripts * update CHANGELOG and the version of @skyscanner/backpack-react-scripts to v9.0.4 * add cache-loader to webpack SSR config but comment that out to not use * change BRS version to v9.1.0 since it is a mirror change * restore build-brs.yml formation as fork branch * add blank space to build-brs.yml to restore formation Co-authored-by: Ollie Curtis <8831547+olliecurtis@users.noreply.github.com> Co-authored-by: Jayson Wu <jayson.wu@skyscanner.net>
* Backpackify * add thread-loader to webpack config * add thread-loader to webpack SSR config but comment that out to not use * add CHANGELOG and upgrade version to v9.1.1 * restore build-brs.yml formation as fork branch Co-authored-by: Ollie Curtis <8831547+olliecurtis@users.noreply.github.com> Co-authored-by: Jayson Wu <jayson.wu@skyscanner.net>
* Backpackify * optimize the usage of thread-loader to fix build:storybook running failed * restore formation of build-brs.yml file * restore react-scripts version to v9.1.0 to make pipeline run normal Co-authored-by: Ollie Curtis <8831547+olliecurtis@users.noreply.github.com> Co-authored-by: Jayson Wu <jayson.wu@skyscanner.net>
* apply cache-loader on ci * fix spell of cache-loader * only using SHOULD_USE_CACHE_LOADER to control and restore formation * restore webpack config formation Co-authored-by: Jayson Wu <jayson.wu@skyscanner.net>
…t performance (#102) * Move cache-loader above resolve-url-loader to get the best performance Co-authored-by: Jayson Wu <jayson.wu@skyscanner.net>
* Add hashes that also factor in project name * added comment * commit runaway formatting Co-authored-by: Darrel Fox <darrel.fox@skyscanner.net>
* uninstall typescript linting dependencies as we did with eslint and eslint-config-react-app as these come from eslint-config-skyscanner * add changelog entry for typescript eslint removal
* set node version to v14.x in workflows
* upgrade sass-loader to v10.x * revert format Co-authored-by: sophia-chen <sophia.chen@skyscanner.net>
They were not added in the latest PR #116 so adding it now as its missing
BRS support node >=12
Merge and update change log of 9.5.1
* extract babelIncludePrefixes feature Co-authored-by: tao.fang <tao.fang@skyscanner.net>
Co-authored-by: tao.fang <tao.fang@skyscanner.net>
Co-authored-by: tao.fang <tao.fang@skyscanner.net>
* Extract cssModules feature Co-authored-by: tao.fang <tao.fang@skyscanner.net>
* extract splitChunks * update require path * add splitChunk annotation
* sassFunctions addon * remove utils/sassFunctions.js * update ssr sassFunctions * update ssr sassFunctions
* prefect feature description * update file
* extract runtimeChunk * update runtimeChunk * reset runtimeChunk
|
Hi @salleyliu! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It shows this error when running npm run build in banana:
./src/components/DetailsPanel/LegSegmentSummary/Times/Times.scss SassError: Could not find encodebase64 function. Refer to https://backpack.github.io/sassdoc/#svgs-mixin-bpk-icon on how to provide it to node-sass. on line 109 of node_modules/bpk-mixins/src/mixins/_svgs.scss, in mixinbpk-icon`from line 31 of src/components/DetailsPanel/LegSegmentSummary/Times/Times.scss
`