Skip to content

Faster builds with react-scripts build --dev#12130

Open
p-avital wants to merge 1 commit into
react:mainfrom
p-avital:patch-2
Open

Faster builds with react-scripts build --dev#12130
p-avital wants to merge 1 commit into
react:mainfrom
p-avital:patch-2

Conversation

@p-avital
Copy link
Copy Markdown

@p-avital p-avital commented Mar 4, 2022

Hello,

I'll be honest, I've been going straight for the simplest solution, and I haven't actually tested it. Definitely review this before merging. I'm mostly doing this PR to try and prompt the maintainers to let such a thing exist.

I feel like there's too big a leap from start to build, as one also spawns a server (not required for my usecase), whereas the other only does production-optimized builds.

This might not be the cleanest way to do it, but I think this would allow a middle ground where one can run fast builds without spawning a server (useful when an other server is already serving the build folder).

Hello,

I'll be honest, I've been going straight for the simplest solution, and I haven't actually tested it. Definitely review this before merging. I'm mostly doing this PR to try and prompt the maintainers to let such a thing exist.

I feel like there's too big a leap from `start` to `build`, as one also spawns a server (not required for my usecase), whereas the other only does production-optimized builds.

This might not be the cleanest way to do it, but I think this would allow a middle ground where one can run fast builds without spawning a server (useful when an other server is already serving the build folder).
@p-avital p-avital requested review from iansu and mrmckeb as code owners March 4, 2022 15:25
@facebook-github-bot
Copy link
Copy Markdown

Hi @p-avital!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants