Skip to content

fix: exclude CJS files with file loader (#11889)#12352

Open
gdethier wants to merge 1 commit into
react:mainfrom
gdethier:main
Open

fix: exclude CJS files with file loader (#11889)#12352
gdethier wants to merge 1 commit into
react:mainfrom
gdethier:main

Conversation

@gdethier
Copy link
Copy Markdown

@gdethier gdethier commented May 2, 2022

This PR fixes #11889. The change has been tested against the code example provided in the issue:

  1. Download the code example
  2. Install dependencies
  3. Eject
  4. Apply the config change described in this PR
  5. Run the app and see that it works as expected.
    Capture d’écran du 2022-05-02 15-51-31

Without the change, one would get this instead:
Capture d’écran du 2022-05-02 15-52-26

@gdethier gdethier requested review from iansu and mrmckeb as code owners May 2, 2022 13:53
@facebook-github-bot
Copy link
Copy Markdown

Hi @gdethier!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@gdethier gdethier changed the title fix: exclude CJS files with file loader (11889) fix: exclude CJS files with file loader (#11889) May 2, 2022
@facebook-github-bot
Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@vezwork
Copy link
Copy Markdown

vezwork commented Sep 7, 2022

This PR is a duplicate of #12021!I believe this would fix #12155. Hoping for this (or another similar PR) to be reviewed and merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CRA5 Bug: require a submodule of a package (i.e. my-package/sub-module) returns a string instead of the module

3 participants