Skip to content

fix: Fix the fixed filename#12383

Open
Rahim-Chan wants to merge 1 commit into
react:mainfrom
Rahim-Chan:fix/filename
Open

fix: Fix the fixed filename#12383
Rahim-Chan wants to merge 1 commit into
react:mainfrom
Rahim-Chan:fix/filename

Conversation

@Rahim-Chan
Copy link
Copy Markdown

@Rahim-Chan Rahim-Chan commented May 11, 2022

WHY:
When I define two entry points.
image
The service will jam. I think two identical files will be produced.

HOW:
Make filename dynamic, it works.
image

@Rahim-Chan Rahim-Chan requested review from iansu and mrmckeb as code owners May 11, 2022 11:13
@facebook-github-bot
Copy link
Copy Markdown

Hi @Rahim-Chan!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@Rahim-Chan
Copy link
Copy Markdown
Author

@iansu @mrmckeb pls checkout

@Rahim-Chan
Copy link
Copy Markdown
Author

Why doesn't anyone care about this?

@Rahim-Chan
Copy link
Copy Markdown
Author

@iansu @mrmckeb please help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants