Skip to content

fix webpack hmr for new api#12422

Open
pan-alexey wants to merge 1 commit into
react:mainfrom
pan-alexey:main
Open

fix webpack hmr for new api#12422
pan-alexey wants to merge 1 commit into
react:mainfrom
pan-alexey:main

Conversation

@pan-alexey
Copy link
Copy Markdown

Current methods are located here and here

Implementation of the validation method [check]|(https://github.com/webpack/webpack/blob/main/lib/hmr/HotModuleReplacement.runtime.js#L259) always return Promise with null or Array of modules

Implementation of the validation method [apply]|(https://github.com/webpack/webpack/blob/main/lib/hmr/HotModuleReplacement.runtime.js#L309) always return Promise with Array of modules

@pan-alexey pan-alexey requested review from iansu and mrmckeb as code owners May 21, 2022 16:50
@facebook-github-bot
Copy link
Copy Markdown

Hi @pan-alexey!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@pan-alexey
Copy link
Copy Markdown
Author

@iansu @mrmckeb ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants