Skip to content

chore: bump jest to version 29 #12662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jean-smaug wants to merge 11 commits into
base: main
Choose a base branch
from
Open

chore: bump jest to version 29 #12662

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
aad335c
chore(react-scripts): update jest to version 28
jean-smaug Aug 13, 2022
e04e99f
chore(all): bump jest to version 28 everywhere
jean-smaug Aug 13, 2022
93c83a4
chore: update lockfile
jean-smaug Aug 13, 2022
826b8aa
add jest-environment-jsdom@28.1.3
jean-smaug Aug 13, 2022
18fb5d9
update jest process functions
jean-smaug Aug 13, 2022
f566b60
replace identity-obj-proxy by jest-scss-transform
jean-smaug Aug 13, 2022
4a9da28
add midding return 'code' in fileTransform
jean-smaug Aug 13, 2022
d5f9641
Revert "replace identity-obj-proxy by jest-scss-transform"
jean-smaug Aug 13, 2022
61e5882
upgrade to jest 29
jean-smaug Sep 17, 2022
6c1ff65
remove snapshot files
jean-smaug Sep 17, 2022
5300f01
regenerate snapshots
jean-smaug Sep 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7,432 changes: 6,110 additions & 1,322 deletions package-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
"get-port": "^5.1.1",
"globby": "^11.0.4",
"husky": "^4.3.8",
"jest": "^27.4.3",
"jest": "^29.0.3",
"lerna": "^4.0.0",
"lerna-changelog": "^2.2.0",
"lint-staged": "^12.1.2",
Expand Down
2 changes: 1 addition & 1 deletion packages/babel-plugin-named-asset-import/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
},
"devDependencies": {
"babel-plugin-tester": "^10.1.0",
"jest": "^27.4.3"
"jest": "^29.0.3"
},
"scripts": {
"test": "jest"
Expand Down
2 changes: 1 addition & 1 deletion packages/confusing-browser-globals/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,6 @@
"index.js"
],
"devDependencies": {
"jest": "^27.4.3"
"jest": "^29.0.3"
}
}
2 changes: 1 addition & 1 deletion packages/create-react-app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,6 @@
},
"devDependencies": {
"cross-env": "^7.0.3",
"jest": "^27.4.3"
"jest": "^29.0.3"
}
}
2 changes: 1 addition & 1 deletion packages/react-dev-utils/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@
},
"devDependencies": {
"cross-env": "^7.0.3",
"jest": "^27.4.3"
"jest": "^29.0.3"
},
"scripts": {
"test": "cross-env FORCE_COLOR=true jest"
Expand Down
5 changes: 3 additions & 2 deletions packages/react-error-overlay/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,15 +38,16 @@
"@babel/code-frame": "^7.16.0",
"@babel/core": "^7.16.0",
"anser": "^2.1.0",
"babel-jest": "^27.4.2",
"babel-jest": "^29.0.3",
"babel-loader": "^8.2.3",
"babel-preset-react-app": "^10.0.1",
"chalk": "^4.1.2",
"chokidar": "^3.5.2",
"cross-env": "^7.0.3",
"flow-bin": "^0.116.0",
"html-entities": "^2.3.2",
"jest": "^27.4.3",
"jest": "^29.0.3",
"jest-environment-jsdom": "^29.0.3",
"jest-fetch-mock": "^3.0.3",
"object-assign": "^4.1.1",
"promise": "^8.1.0",
Expand Down
4 changes: 2 additions & 2 deletions packages/react-error-overlay/src/__tests__/__snapshots__/lines-around.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`should return lines around from a string 1`] = `
Array [
[
ScriptLine {
"content": "two",
"highlight": false,
Expand Down Expand Up @@ -31,7 +31,7 @@ Array [
`;

exports[`should return lines around from an array 1`] = `
Array [
[
ScriptLine {
"content": "two",
"highlight": false,
Expand Down
6 changes: 3 additions & 3 deletions packages/react-error-overlay/src/__tests__/__snapshots__/unmapper.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`default context & unfound source 1`] = `
Array [
[
StackFrame {
"_originalColumnNumber": null,
"_originalFileName": "B.js",
"_originalFunctionName": "div",
"_originalLineNumber": 8,
"_originalScriptCode": Array [
"_originalScriptCode": [
ScriptLine {
"content": " return (",
"highlight": false,
Expand Down Expand Up @@ -44,7 +44,7 @@ Array [
"lineNumber": 11,
},
],
"_scriptCode": Array [
"_scriptCode": [
ScriptLine {
"content": " },",
"highlight": false,
Expand Down
2 changes: 1 addition & 1 deletion packages/react-error-overlay/src/__tests__/parser/__snapshots__/chrome.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`stack with eval 1`] = `
Array [
[
StackFrame {
"_originalColumnNumber": null,
"_originalFileName": null,
Expand Down
10 changes: 5 additions & 5 deletions packages/react-error-overlay/src/__tests__/parser/__snapshots__/firefox.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`eval 1 1`] = `
Array [
[
StackFrame {
"_originalColumnNumber": null,
"_originalFileName": null,
Expand Down Expand Up @@ -42,7 +42,7 @@ Array [
`;

exports[`eval 2 1`] = `
Array [
[
StackFrame {
"_originalColumnNumber": null,
"_originalFileName": null,
Expand Down Expand Up @@ -71,7 +71,7 @@ Array [
`;

exports[`stack with eval 1`] = `
Array [
[
StackFrame {
"_originalColumnNumber": null,
"_originalFileName": null,
Expand Down Expand Up @@ -124,7 +124,7 @@ Array [
`;

exports[`v14 to v29 1`] = `
Array [
[
StackFrame {
"_originalColumnNumber": null,
"_originalFileName": null,
Expand Down Expand Up @@ -177,7 +177,7 @@ Array [
`;

exports[`v30+ 1`] = `
Array [
[
StackFrame {
"_originalColumnNumber": null,
"_originalFileName": null,
Expand Down
2 changes: 1 addition & 1 deletion packages/react-error-overlay/src/__tests__/parser/__snapshots__/react.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`15.y.z 1`] = `
Array [
[
StackFrame {
"_originalColumnNumber": null,
"_originalFileName": null,
Expand Down
2 changes: 1 addition & 1 deletion packages/react-error-overlay/src/__tests__/parser/__snapshots__/safari.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`stack with eval 1`] = `
Array [
[
StackFrame {
"_originalColumnNumber": null,
"_originalFileName": null,
Expand Down
4 changes: 3 additions & 1 deletion packages/react-scripts/config/jest/cssTransform.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,9 @@

module.exports = {
process() {
return 'module.exports = {};';
return {
code: 'module.exports = {};',
};
},
Comment on lines 15 to 19
Copy link
Copy Markdown
Author

@jean-smaug jean-smaug Aug 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Returning string isn't allowed anymore with v28

https://jestjs.io/docs/upgrading-to-jest28#transformer

getCacheKey() {
// The output is always the same.
Expand Down
10 changes: 7 additions & 3 deletions packages/react-scripts/config/jest/fileTransform.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ module.exports = {
pascalCase: true,
});
const componentName = `Svg${pascalCaseFilename}`;
return `const React = require('react');
return {
code: `const React = require('react');
module.exports = {
__esModule: true,
default: ${assetFilename},
Expand All @@ -32,9 +33,12 @@ module.exports = {
})
};
}),
};`;
};`,
};
}

return `module.exports = ${assetFilename};`;
return {
code: `module.exports = ${assetFilename};`,
};
},
};
2 changes: 1 addition & 1 deletion packages/react-scripts/fixtures/kitchensink/template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"package": {
"dependencies": {
"bootstrap": "4.3.1",
"jest": "27.1.0",
"jest": "29.0.3",
"node-sass": "6.x",
"normalize.css": "7.0.0",
"prop-types": "15.7.2",
Expand Down
9 changes: 5 additions & 4 deletions packages/react-scripts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"@babel/core": "^7.16.0",
"@pmmmwh/react-refresh-webpack-plugin": "^0.5.3",
"@svgr/webpack": "^5.5.0",
"babel-jest": "^27.4.2",
"babel-jest": "^29.0.3",
"babel-loader": "^8.2.3",
"babel-plugin-named-asset-import": "^0.3.8",
"babel-preset-react-app": "^10.0.1",
Expand All @@ -50,9 +50,10 @@
"fs-extra": "^10.0.0",
"html-webpack-plugin": "^5.5.0",
"identity-obj-proxy": "^3.0.0",
"jest": "^27.4.3",
"jest-resolve": "^27.4.2",
"jest-watch-typeahead": "^1.0.0",
"jest": "^29.0.3",
"jest-environment-jsdom": "^29.0.3",
"jest-resolve": "^29.0.3",
"jest-watch-typeahead": "^2.0.0",
"mini-css-extract-plugin": "^2.4.5",
"postcss": "^8.4.4",
"postcss-flexbugs-fixes": "^5.0.2",
Expand Down
5 changes: 0 additions & 5 deletions test/fixtures/mjs-support/__snapshots__/index.test.js.snap
View file
Open in desktop

This file was deleted.

Loading