Skip to content

Sass: dependency to dev-dependency #13308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gilhanan wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −5
Open

Sass: dependency to dev-dependency #13308

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions docusaurus/docs/adding-a-sass-stylesheet.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ Following this rule often makes CSS preprocessors less useful, as features like
To use Sass, first install `sass`:

```sh
$ npm install sass
$ npm install --save-dev sass
# or
$ yarn add sass
$ yarn add sass --dev
```

Now you can rename `src/App.css` to `src/App.scss` and update `src/App.js` to import `src/App.scss`.
Expand Down Expand Up @@ -61,8 +61,8 @@ To use imports relative to a path you specify, you can add a [`.env` file](https
>
> ```sh
> $ npm uninstall node-sass
> $ npm install sass
> $ npm install sass --save-dev
> # or
> $ yarn remove node-sass
> $ yarn add sass
> $ yarn add --dev sass
> ```
2 changes: 1 addition & 1 deletion packages/react-dev-utils/formatWebpackMessages.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ function formatMessage(message) {
if (lines[1] && lines[1].match(/Cannot find module.+sass/)) {
lines[1] = 'To import Sass files, you first need to install sass.\n';
lines[1] +=
'Run `npm install sass` or `yarn add sass` inside your workspace.';
'Run `npm install sass --save-dev` or `yarn add --dev sass` inside your workspace.';
}

message = lines.join('\n');
Expand Down