fixed the bad request url at banner#13674
Open
chandankumarm55 wants to merge 3 commits into
Open
Conversation
Author
|
@akashprasher oh yeah but i didnt change anything wait let me check with main branch code |
Author
|
@akashprasher can u check now i have removed the {' '} |
joaugustoo
reviewed
Oct 16, 2024
joaugustoo
left a comment
joaugustoo
left a comment
There was a problem hiding this comment.
After removing the {' '}, everything seems to be correct in the code. Thank you!
Author
|
Please Merge this pull request ...!! |
Author
|
Can u please close this PR as soon as possible please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the bad resource link mentioned in issue #13649. The issue was that the app was making a request to the URL camo.githubusercontent.com, which resulted in a 404 page not found error. I downloaded the original image and added it locally to avoid any external requests, ensuring the image will load permanently. The link has been updated accordingly.
Issue #13649 is now resolved.