Skip to content

Add typescript-plugin-css-modules#5877

Closed
mrmckeb wants to merge 1 commit into
react:masterfrom
mrmckeb:feature/typescript-css-modules
Closed

Add typescript-plugin-css-modules#5877
mrmckeb wants to merge 1 commit into
react:masterfrom
mrmckeb:feature/typescript-css-modules

Conversation

@mrmckeb
Copy link
Copy Markdown
Contributor

@mrmckeb mrmckeb commented Nov 22, 2018

Resolves #5677.

This can be tested by running:

npx git+ssh://git@github.com:mrmckeb/create-react-app.git#cra \
  test-app \
  --scripts-version=git+ssh://git@github.com:mrmckeb/create-react-app.git#react-scripts-typescript  \
  --typescript

@amshtemp
Copy link
Copy Markdown

Just tested it. Works like a charm.
Would it be a good idea to put a comment on how to enable it?

@mrmckeb
Copy link
Copy Markdown
Contributor Author

mrmckeb commented Nov 22, 2018

Hi @amshtemp, thanks for the feedback. Do you mean a comment in documentation? Or a comment in command line on how to use it with your IDE (mostly VSCode)?

Possibly docs, then linking to those docs from the command line?

@amshtemp
Copy link
Copy Markdown

@mrmckeb,
I don't know about the command line thing... isn't that a bit invasive?
I guess the docs is a better place, with cross referencing between the IDE and CSS Modules sections.

Maybe a better Idea is to have VSCode team adopt this. Do you think there is a chance? I'm asking because MS use their own CSS language server and this module fit that task well.

@mrmckeb
Copy link
Copy Markdown
Contributor Author

mrmckeb commented Nov 22, 2018

Docs would make sense. I understand what you're saying, but this solution works in all IDEs that support TypeScript, it's not related to VSCode.

@Timer Timer added this to the 3.0 milestone Nov 23, 2018
@mrmckeb
Copy link
Copy Markdown
Contributor Author

mrmckeb commented Mar 20, 2019

Closing this off until plugins work at build-time.

@mrmckeb mrmckeb closed this Mar 20, 2019
@mrmckeb mrmckeb deleted the feature/typescript-css-modules branch March 20, 2019 17:39
@lock lock Bot locked and limited conversation to collaborators Mar 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants