Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
What do you think about adding It's supported in both browsers and node, and would be a replacement for |
Contributor
Author
The plan is for RN (or Expo) to define properties using the Metro could define some more defaults though.. |
satya164
reviewed
Apr 27, 2025
Comment on lines
+31
to
+34
| __getImportMetaProperties: module => { | ||
| return { | ||
| url: new URL(String(module.id), 'metro://'), | ||
| }; |
Contributor
There was a problem hiding this comment.
so this code will be added to react native itself?
Contributor
Author
There was a problem hiding this comment.
Yep, similar to how the framework defines async imports, eg:
Currently, Metro leaves `import.meta` accesses untransformed, but provides no `import` pseudoglobal, so (unless polyfilled) this throws at runtime. `import.meta` is [specified](https://tc39.es/ecma262/multipage/ecmascript-language-expressions.html#sec-meta-properties) as a writable null-proto object. Though the spec is silent on any properties, it provides a mechanism ([`HostGetImportMetaProperties`](https://tc39.es/ecma262/multipage/ecmascript-language-expressions.html#sec-hostgetimportmetaproperties)) for hosts to set properties, given a module object. Eg: `url`, `resolve` are defined by Node.js and browsers (and notably `env` by Vite). We emulate that mechanism here with the `__getImportMetaProperties(module) => {[key: string]: mixed}` optional, framework-defined global function.
|
any progress on this? |
IgnisDa
added a commit
to IgnisDa/ryot
that referenced
this pull request
May 2, 2026
Metro 0.82+ (Expo 53+) enables package.json exports by default. When source uses ESM import syntax, Metro asserts the 'import' condition, which resolves jotai to its .mjs build containing import.meta.env.MODE — a Vite-ism. Metro's web output is a plain <script> (not type=module), so the browser throws a SyntaxError before any app code runs. babel-preset-expo gained unstable_transformImportMeta in SDK 53 as an opt-in to compile import.meta away at build time. Enabling it here is the correct fix; no metro.config.js changes needed. Tracked: pmndrs/jotai#3041 Metro fix in progress: react/metro#1494 Generated-by: OpenCode Model: amazon-bedrock/anthropic.claude-sonnet-4-6
IgnisDa
added a commit
to IgnisDa/ryot
that referenced
this pull request
May 31, 2026
Metro 0.82+ (Expo 53+) enables package.json exports by default. When source uses ESM import syntax, Metro asserts the 'import' condition, which resolves jotai to its .mjs build containing import.meta.env.MODE — a Vite-ism. Metro's web output is a plain <script> (not type=module), so the browser throws a SyntaxError before any app code runs. babel-preset-expo gained unstable_transformImportMeta in SDK 53 as an opt-in to compile import.meta away at build time. Enabling it here is the correct fix; no metro.config.js changes needed. Tracked: pmndrs/jotai#3041 Metro fix in progress: react/metro#1494 Generated-by: OpenCode Model: amazon-bedrock/anthropic.claude-sonnet-4-6
IgnisDa
added a commit
to IgnisDa/ryot
that referenced
this pull request
May 31, 2026
Metro 0.82+ (Expo 53+) enables package.json exports by default. When source uses ESM import syntax, Metro asserts the 'import' condition, which resolves jotai to its .mjs build containing import.meta.env.MODE — a Vite-ism. Metro's web output is a plain <script> (not type=module), so the browser throws a SyntaxError before any app code runs. babel-preset-expo gained unstable_transformImportMeta in SDK 53 as an opt-in to compile import.meta away at build time. Enabling it here is the correct fix; no metro.config.js changes needed. Tracked: pmndrs/jotai#3041 Metro fix in progress: react/metro#1494 Generated-by: OpenCode Model: amazon-bedrock/anthropic.claude-sonnet-4-6
IgnisDa
added a commit
to IgnisDa/ryot
that referenced
this pull request
Jul 13, 2026
Metro 0.82+ (Expo 53+) enables package.json exports by default. When source uses ESM import syntax, Metro asserts the 'import' condition, which resolves jotai to its .mjs build containing import.meta.env.MODE — a Vite-ism. Metro's web output is a plain <script> (not type=module), so the browser throws a SyntaxError before any app code runs. babel-preset-expo gained unstable_transformImportMeta in SDK 53 as an opt-in to compile import.meta away at build time. Enabling it here is the correct fix; no metro.config.js changes needed. Tracked: pmndrs/jotai#3041 Metro fix in progress: react/metro#1494 Generated-by: OpenCode Model: amazon-bedrock/anthropic.claude-sonnet-4-6
IgnisDa
added a commit
to IgnisDa/ryot
that referenced
this pull request
Jul 13, 2026
Metro 0.82+ (Expo 53+) enables package.json exports by default. When source uses ESM import syntax, Metro asserts the 'import' condition, which resolves jotai to its .mjs build containing import.meta.env.MODE — a Vite-ism. Metro's web output is a plain <script> (not type=module), so the browser throws a SyntaxError before any app code runs. babel-preset-expo gained unstable_transformImportMeta in SDK 53 as an opt-in to compile import.meta away at build time. Enabling it here is the correct fix; no metro.config.js changes needed. Tracked: pmndrs/jotai#3041 Metro fix in progress: react/metro#1494 Generated-by: OpenCode Model: amazon-bedrock/anthropic.claude-sonnet-4-6
IgnisDa
added a commit
to IgnisDa/ryot
that referenced
this pull request
Jul 15, 2026
Metro 0.82+ (Expo 53+) enables package.json exports by default. When source uses ESM import syntax, Metro asserts the 'import' condition, which resolves jotai to its .mjs build containing import.meta.env.MODE — a Vite-ism. Metro's web output is a plain <script> (not type=module), so the browser throws a SyntaxError before any app code runs. babel-preset-expo gained unstable_transformImportMeta in SDK 53 as an opt-in to compile import.meta away at build time. Enabling it here is the correct fix; no metro.config.js changes needed. Tracked: pmndrs/jotai#3041 Metro fix in progress: react/metro#1494 Generated-by: OpenCode Model: amazon-bedrock/anthropic.claude-sonnet-4-6
IgnisDa
added a commit
to IgnisDa/ryot
that referenced
this pull request
Jul 15, 2026
Metro 0.82+ (Expo 53+) enables package.json exports by default. When source uses ESM import syntax, Metro asserts the 'import' condition, which resolves jotai to its .mjs build containing import.meta.env.MODE — a Vite-ism. Metro's web output is a plain <script> (not type=module), so the browser throws a SyntaxError before any app code runs. babel-preset-expo gained unstable_transformImportMeta in SDK 53 as an opt-in to compile import.meta away at build time. Enabling it here is the correct fix; no metro.config.js changes needed. Tracked: pmndrs/jotai#3041 Metro fix in progress: react/metro#1494 Generated-by: OpenCode Model: amazon-bedrock/anthropic.claude-sonnet-4-6
IgnisDa
added a commit
to IgnisDa/ryot
that referenced
this pull request
Jul 15, 2026
Metro 0.82+ (Expo 53+) enables package.json exports by default. When source uses ESM import syntax, Metro asserts the 'import' condition, which resolves jotai to its .mjs build containing import.meta.env.MODE — a Vite-ism. Metro's web output is a plain <script> (not type=module), so the browser throws a SyntaxError before any app code runs. babel-preset-expo gained unstable_transformImportMeta in SDK 53 as an opt-in to compile import.meta away at build time. Enabling it here is the correct fix; no metro.config.js changes needed. Tracked: pmndrs/jotai#3041 Metro fix in progress: react/metro#1494 Generated-by: OpenCode Model: amazon-bedrock/anthropic.claude-sonnet-4-6
IgnisDa
added a commit
to IgnisDa/ryot
that referenced
this pull request
Jul 19, 2026
Metro 0.82+ (Expo 53+) enables package.json exports by default. When source uses ESM import syntax, Metro asserts the 'import' condition, which resolves jotai to its .mjs build containing import.meta.env.MODE — a Vite-ism. Metro's web output is a plain <script> (not type=module), so the browser throws a SyntaxError before any app code runs. babel-preset-expo gained unstable_transformImportMeta in SDK 53 as an opt-in to compile import.meta away at build time. Enabling it here is the correct fix; no metro.config.js changes needed. Tracked: pmndrs/jotai#3041 Metro fix in progress: react/metro#1494 Generated-by: OpenCode Model: amazon-bedrock/anthropic.claude-sonnet-4-6
IgnisDa
added a commit
to IgnisDa/ryot
that referenced
this pull request
Jul 20, 2026
Metro 0.82+ (Expo 53+) enables package.json exports by default. When source uses ESM import syntax, Metro asserts the 'import' condition, which resolves jotai to its .mjs build containing import.meta.env.MODE — a Vite-ism. Metro's web output is a plain <script> (not type=module), so the browser throws a SyntaxError before any app code runs. babel-preset-expo gained unstable_transformImportMeta in SDK 53 as an opt-in to compile import.meta away at build time. Enabling it here is the correct fix; no metro.config.js changes needed. Tracked: pmndrs/jotai#3041 Metro fix in progress: react/metro#1494 Generated-by: OpenCode Model: amazon-bedrock/anthropic.claude-sonnet-4-6
IgnisDa
added a commit
to IgnisDa/ryot
that referenced
this pull request
Jul 24, 2026
Metro 0.82+ (Expo 53+) enables package.json exports by default. When source uses ESM import syntax, Metro asserts the 'import' condition, which resolves jotai to its .mjs build containing import.meta.env.MODE — a Vite-ism. Metro's web output is a plain <script> (not type=module), so the browser throws a SyntaxError before any app code runs. babel-preset-expo gained unstable_transformImportMeta in SDK 53 as an opt-in to compile import.meta away at build time. Enabling it here is the correct fix; no metro.config.js changes needed. Tracked: pmndrs/jotai#3041 Metro fix in progress: react/metro#1494 Generated-by: OpenCode Model: amazon-bedrock/anthropic.claude-sonnet-4-6
IgnisDa
added a commit
to IgnisDa/ryot
that referenced
this pull request
Jul 24, 2026
Metro 0.82+ (Expo 53+) enables package.json exports by default. When source uses ESM import syntax, Metro asserts the 'import' condition, which resolves jotai to its .mjs build containing import.meta.env.MODE — a Vite-ism. Metro's web output is a plain <script> (not type=module), so the browser throws a SyntaxError before any app code runs. babel-preset-expo gained unstable_transformImportMeta in SDK 53 as an opt-in to compile import.meta away at build time. Enabling it here is the correct fix; no metro.config.js changes needed. Tracked: pmndrs/jotai#3041 Metro fix in progress: react/metro#1494 Generated-by: OpenCode Model: amazon-bedrock/anthropic.claude-sonnet-4-6
IgnisDa
added a commit
to IgnisDa/ryot
that referenced
this pull request
Jul 24, 2026
Metro 0.82+ (Expo 53+) enables package.json exports by default. When source uses ESM import syntax, Metro asserts the 'import' condition, which resolves jotai to its .mjs build containing import.meta.env.MODE — a Vite-ism. Metro's web output is a plain <script> (not type=module), so the browser throws a SyntaxError before any app code runs. babel-preset-expo gained unstable_transformImportMeta in SDK 53 as an opt-in to compile import.meta away at build time. Enabling it here is the correct fix; no metro.config.js changes needed. Tracked: pmndrs/jotai#3041 Metro fix in progress: react/metro#1494 Generated-by: OpenCode Model: amazon-bedrock/anthropic.claude-sonnet-4-6
IgnisDa
added a commit
to IgnisDa/ryot
that referenced
this pull request
Jul 24, 2026
Metro 0.82+ (Expo 53+) enables package.json exports by default. When source uses ESM import syntax, Metro asserts the 'import' condition, which resolves jotai to its .mjs build containing import.meta.env.MODE — a Vite-ism. Metro's web output is a plain <script> (not type=module), so the browser throws a SyntaxError before any app code runs. babel-preset-expo gained unstable_transformImportMeta in SDK 53 as an opt-in to compile import.meta away at build time. Enabling it here is the correct fix; no metro.config.js changes needed. Tracked: pmndrs/jotai#3041 Metro fix in progress: react/metro#1494 Generated-by: OpenCode Model: amazon-bedrock/anthropic.claude-sonnet-4-6
IgnisDa
added a commit
to IgnisDa/ryot
that referenced
this pull request
Jul 26, 2026
Metro 0.82+ (Expo 53+) enables package.json exports by default. When source uses ESM import syntax, Metro asserts the 'import' condition, which resolves jotai to its .mjs build containing import.meta.env.MODE — a Vite-ism. Metro's web output is a plain <script> (not type=module), so the browser throws a SyntaxError before any app code runs. babel-preset-expo gained unstable_transformImportMeta in SDK 53 as an opt-in to compile import.meta away at build time. Enabling it here is the correct fix; no metro.config.js changes needed. Tracked: pmndrs/jotai#3041 Metro fix in progress: react/metro#1494 Generated-by: OpenCode Model: amazon-bedrock/anthropic.claude-sonnet-4-6
IgnisDa
added a commit
to IgnisDa/ryot
that referenced
this pull request
Jul 26, 2026
Metro 0.82+ (Expo 53+) enables package.json exports by default. When source uses ESM import syntax, Metro asserts the 'import' condition, which resolves jotai to its .mjs build containing import.meta.env.MODE — a Vite-ism. Metro's web output is a plain <script> (not type=module), so the browser throws a SyntaxError before any app code runs. babel-preset-expo gained unstable_transformImportMeta in SDK 53 as an opt-in to compile import.meta away at build time. Enabling it here is the correct fix; no metro.config.js changes needed. Tracked: pmndrs/jotai#3041 Metro fix in progress: react/metro#1494 Generated-by: OpenCode Model: amazon-bedrock/anthropic.claude-sonnet-4-6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, Metro leaves
import.metaaccesses untransformed, but provides noimportpseudoglobal, so (unless polyfilled) this throws at runtime.import.metais specified as a writable null-proto object. Though the spec is silent on any properties, it provides a mechanism (HostGetImportMetaProperties) for hosts to set properties, given a module object. Eg:url,resolveare defined by Node.js and browsers (and notablyenvby Vite).We emulate that mechanism here with the
__getImportMetaProperties(module) => {[key: string]: mixed}optional, framework-defined global function.