Skip to content

Types: clean up API snapshots, accept omitted props where we accept void - #1885

Closed
robhogan wants to merge 1 commit into
mainfrom
pr1885
Closed

Types: clean up API snapshots, accept omitted props where we accept void#1885
robhogan wants to merge 1 commit into
mainfrom
pr1885

Conversation

@robhogan

Copy link
Copy Markdown
Collaborator

Tidy up some API snapshots (in preparation for moving Expo onto using Metro types directly)

  • Label some previously anonymous parameters
  • Accept omitted props in input positions where we already accepted undefined

This is behaviour preserving

Changelog: Internal

Test plan:
Flow
yarn run build-api-snapshots + inspect

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 28, 2026
Tidy up some API snapshots (in preparation for moving Expo onto using Metro types directly)

 - Label some previously anonymous parameters
 - Accept omitted props in input positions where we already accepted `undefined`

This is behaviour preserving

Changelog: Internal

Test plan:
Flow
`yarn run build-api-snapshots` + inspect
@facebook-github-tools facebook-github-tools Bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Aug 28, 2026
@meta-codesync

meta-codesync Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

@GijsWeterings has imported this pull request. If you are a Meta employee, you can view this in D117868951.

robhogan added a commit that referenced this pull request Sep 2, 2026
Pick #1885, type-only non-breaking changes.

Test plan:
`yarn run flow`
`yarn run build-ts-defs` -> no changes
@meta-codesync meta-codesync Bot closed this in 75d0c93 Sep 4, 2026
@meta-codesync meta-codesync Bot added the Merged label Sep 4, 2026
@meta-codesync

meta-codesync Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

@GijsWeterings merged this pull request in 75d0c93.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant