iOS: Fix autoCorrect doesn't revert to initial state

[rigdern]

There's an inconsistency in autoCorrect's default state:

• If you don't specify a value for autoCorrect, it defaults to on.
• If you specify true/false for autoCorrect and later specify null, autoCorrect turns off. It should have reverted to its initial state of on.

The reason for this discrepancy is that autoCorrect is exposed to JS as a boolean but it is actually an enum with three states in native:

• UITextAutocorrectionTypeDefault (the default value)
• UITextAutocorrectionTypeYes
• UITextAutocorrectionTypeNo

This is fixed by explicitly mapping JS null to UITextAutocorrectionTypeDefault.

Test plan (required)

Verified that switching autoCorrect between true, false, and null all work correctly in single line and multiline TextInputs.

Adam Comella
Microsoft Corp.

[facebook-github-bot]

By analyzing the blame information on this pull request, we identified @javache and @janicduplessis to be potential reviewers.

[javache]

nit: use correct type here UITextAutocorrectionType

Instead of repeating the logic here, extract this logic to an RCTConvert category.

[rigdern]

@javache Thanks for the feedback. I pushed a change to address your feedback and rebased my branch on master.

In my original change, I didn't implement an RCTConvert method for UITextAutocorrectionType because I figured my implementation deviated from the way somebody would expect the converter to work. Since it's an enum, the expected implementation would be something like:

RCT_ENUM_CONVERTER(UITextAutocorrectionType, (@{
  @"no": @(UITextAutocorrectionTypeNo),
  @"yes": @(UITextAutocorrectionTypeYes),
  @"default": @(UITextAutocorrectionDefault),
}), UITextAutocorrectionTypeDefault, integerValue)

Whereas my actual implementation which converts JS booleans to native enum values is a little unusual.

By the way, what's the reasoning for RCTConvertEnumValue special casing numbers? When json is a number, it appears to return it and ignore the value that particular key was supposed to map to. That seems surprising.

[javache]

I'm not sure if the special casing for numbers is actually used. It allows you to just use the integers the enum maps to on the JS side to avoid passing over strings.

[facebook-github-bot]

@javache has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.