Skip to content

Update ListView Basics to use FlatList, SectionList.#14210

Closed
hramos wants to merge 3 commits into
masterfrom
using-flatlist
Closed

Update ListView Basics to use FlatList, SectionList.#14210
hramos wants to merge 3 commits into
masterfrom
using-flatlist

Conversation

@hramos

@hramos hramos commented May 26, 2017

Copy link
Copy Markdown
Contributor

Motivation (required)

The new list views, FlatList and SectionList, are recommended over ListView.

Test Plan (required)

Built website on localhost and verified the guide is rendered correctly.

screencapture-localhost-8079-react-native-docs-using-a-listview-html-1495834607096

@facebook-github-bot facebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels May 26, 2017
: 'ios';
var name = params.name
? decodeURIComponent(params.name)
: 'Example';

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blame Prettier for this.

const PropTypes = require('prop-types');

const LatestSDKVersion = '15.0.0';
const LatestSDKVersion = '16.0.0';

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not using 17 here because the Snack player doesn't seem to support it.

@facebook-github-bot facebook-github-bot added GH Review: accepted Import Started This pull request has been imported. This does not imply the PR has been approved. and removed GH Review: review-needed labels May 30, 2017
@facebook-github-bot

Copy link
Copy Markdown
Contributor

@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot

Copy link
Copy Markdown
Contributor

I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification.

@facebook-github-bot facebook-github-bot added Import Failed and removed Import Started This pull request has been imported. This does not imply the PR has been approved. labels May 31, 2017
@facebook-github-bot facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Jun 2, 2017
@facebook-github-bot

Copy link
Copy Markdown
Contributor

@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@hramos hramos deleted the using-flatlist branch June 2, 2017 22:11
hramos added a commit that referenced this pull request Jun 6, 2017
Summary:
The new list views, FlatList and SectionList, are recommended over ListView.

Built website on localhost and verified the guide is rendered correctly.

![screencapture-localhost-8079-react-native-docs-using-a-listview-html-1495834607096](https://cloud.githubusercontent.com/assets/165856/26513523/c5d2913a-4220-11e7-8c8d-68bb12c75736.png)
Closes #14210

Differential Revision: D5149151

Pulled By: hramos

fbshipit-source-id: f28f02ee8893c4723c73d610b96ccda51cc31410
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Import Started This pull request has been imported. This does not imply the PR has been approved. JavaScript

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants