[createReactClass] Remove createReactClass from ProgressBarAndroidExample - #21874
Closed
exced wants to merge 4 commits into
Closed
[createReactClass] Remove createReactClass from ProgressBarAndroidExample#21874exced wants to merge 4 commits into
exced wants to merge 4 commits into
Conversation
facebook-github-bot
added
the
CLA Signed
analysis-bot
suggested changes
Oct 20, 2018
analysis-bot
left a comment
analysis-bot
left a comment
There was a problem hiding this comment.
Code analysis results:
eslintfound some issues.
| }; | ||
|
|
||
| class MovingBar extends React.Component<MovingBarProps, MovingBarState> { | ||
| _intervalID: (null: ?IntervalID); |
There was a problem hiding this comment.
null: Parsing error: Unexpected token, expected ")"
27 |
28 | class MovingBar extends React.Component<MovingBarProps, MovingBarState> {
29 | _intervalID: (null: ?IntervalID);
| ^
30 |
31 | state = {
32 | progress: 0,
RSNara
changed the title
Contributor
|
It looks like there are flow errors: |
Contributor
Author
|
I fixed the ESLint issues. Besides I don't have any Flow errors locally, is the config different ? |
Contributor
|
You need to run with the Android config to check |
Contributor
Author
|
@TheSavior I updated Props to fit ProgressBarAndroid component. I also exported its props to make it handier for me |
15 tasks
facebook-github-bot
left a comment
facebook-github-bot
left a comment
Contributor
There was a problem hiding this comment.
RSNara has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Collaborator
rozele
pushed a commit
to microsoft/react-native-windows
that referenced
this pull request
Apr 14, 2019
Summary: Related to #21581 This PR was already opened here react/react-native#21600 but seems to be inactive. Remove createReactClass from ProgressBarAndroidExample. - `yarn run flow` && `yarn run flow-check-android` succeed. - RNTester app ProgressBarAndroidExample on Android. [GENERAL] [ENHANCEMENT] [ProgressBarAndroidExample.android.js] - rm createReactClass Pull Request resolved: react/react-native#21874 Reviewed By: TheSavior Differential Revision: D12827689 Pulled By: RSNara fbshipit-source-id: 46c70ea67dddf5d928fe936a28ef4a0a929d127f
t-nanava
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Jun 17, 2019
Summary: Related to react#21581 This PR was already opened here react#21600 but seems to be inactive. Remove createReactClass from ProgressBarAndroidExample. - `yarn run flow` && `yarn run flow-check-android` succeed. - RNTester app ProgressBarAndroidExample on Android. [GENERAL] [ENHANCEMENT] [ProgressBarAndroidExample.android.js] - rm createReactClass Pull Request resolved: react#21874 Reviewed By: TheSavior Differential Revision: D12827689 Pulled By: RSNara fbshipit-source-id: 46c70ea67dddf5d928fe936a28ef4a0a929d127f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #21581
This PR was already opened here #21600 but seems to be inactive.
Remove createReactClass from ProgressBarAndroidExample.
Test Plan:
yarn run flow&&yarn run flow-check-androidsucceed.Release Notes:
[GENERAL] [ENHANCEMENT] [ProgressBarAndroidExample.android.js] - rm createReactClass