Set ReactTextInput's placeholder ellipsize mode#29664
Conversation
This is only a placeholder workaround for #29663. The real solution would be to export a `@ReactProp` called `ellipsizeMode`, which will then take care of the placeholder ellipsize rendering.
|
Base commit: dffec8b |
Base commit: dffec8b |
| @ReactProp(name = "placeholder") | ||
| public void setPlaceholder(ReactEditText view, @Nullable String placeholder) { | ||
| view.setHint(placeholder); | ||
| view.setEllipsize(TextUtils.TruncateAt.END); |
There was a problem hiding this comment.
how will this work in a multiline TextInput? Thanks a lot for the PR 🙏 ☮️
There was a problem hiding this comment.
I haven't tried it yet, will do next week
|
Any ideas when this will get merged? Asking for a friend 👀 |
|
+1 on this, curious on if this is still in the works @mrousavy |
|
It's hard getting PRs merged when you're not a facebook employee. Don't know when (or if at all) they're gonna merge it, I'm just giving them the opportunity to do so. |
|
@mrousavy doesn't work for me :( any other solutions found? It's breaking the design. |
|
Still have the issue |
|
This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
|
This PR was closed because it has been stalled for 7 days with no activity. |
This is only a placeholder workaround for #29663.
The real solution would be to export a
@ReactPropcalledellipsizeMode, which will then take care of the placeholder ellipsize rendering.Summary
Changelog
[CATEGORY] [TYPE] - Message
Test Plan