Skip to content

Set ReactTextInput's placeholder ellipsize mode#29664

Closed
mrousavy wants to merge 1 commit into
react:mainfrom
mrousavy:patch-1
Closed

Set ReactTextInput's placeholder ellipsize mode#29664
mrousavy wants to merge 1 commit into
react:mainfrom
mrousavy:patch-1

Conversation

@mrousavy

Copy link
Copy Markdown
Contributor

This is only a placeholder workaround for #29663.

The real solution would be to export a @ReactProp called ellipsizeMode, which will then take care of the placeholder ellipsize rendering.

Summary

Changelog

[CATEGORY] [TYPE] - Message

Test Plan

This is only a placeholder workaround for #29663. 

The real solution would be to export a `@ReactProp` called `ellipsizeMode`, which will then take care of the placeholder ellipsize rendering.
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 16, 2020
@pull-bot

Copy link
Copy Markdown
Messages
📖

📋 Verify Changelog Format - A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

DetailsCATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Generated by 🚫 dangerJS against dfb2f22

@analysis-bot

Copy link
Copy Markdown
Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,003,189 159
android hermes armeabi-v7a 6,666,780 137
android hermes x86 7,423,492 137
android hermes x86_64 7,314,387 140
android jsc arm64-v8a 9,162,948 150
android jsc armeabi-v7a 8,818,665 137
android jsc x86 9,011,319 129
android jsc x86_64 9,588,413 130

Base commit: dffec8b

@analysis-bot

Copy link
Copy Markdown
Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: dffec8b

@ReactProp(name = "placeholder")
public void setPlaceholder(ReactEditText view, @Nullable String placeholder) {
view.setHint(placeholder);
view.setEllipsize(TextUtils.TruncateAt.END);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how will this work in a multiline TextInput? Thanks a lot for the PR 🙏 ☮️

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tried it yet, will do next week

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tried it yet?

@lemusthelroy

Copy link
Copy Markdown

Any ideas when this will get merged? Asking for a friend 👀

@KieranVieira

Copy link
Copy Markdown

+1 on this, curious on if this is still in the works @mrousavy

@mrousavy

mrousavy commented Jul 1, 2021

Copy link
Copy Markdown
Contributor Author

It's hard getting PRs merged when you're not a facebook employee. Don't know when (or if at all) they're gonna merge it, I'm just giving them the opportunity to do so.
If you benefit from my changes, fork react-native and apply them (or use patch-package) in the meantime

@damian-balas

Copy link
Copy Markdown

@mrousavy doesn't work for me :( any other solutions found? It's breaking the design.

@minhchienwikipedia

Copy link
Copy Markdown

Still have the issue

@github-actions

Copy link
Copy Markdown

This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions Bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Jun 26, 2023
@github-actions

github-actions Bot commented Jul 3, 2023

Copy link
Copy Markdown

This PR was closed because it has been stalled for 7 days with no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Stale There has been a lack of activity on this issue and it may be closed soon.

Projects

None yet

Development

Successfully merging this pull request may close these issues.