fix: release branches miss workspace dependencies

[grabbou]

Summary

On the CI, e.g. inside publish-npm.js, we're missing shelljs dependency, which comes from repo-config package. This error started happening after introduction of Yarn workspaces.

During bump-oss-version.js, we remove private and workspaces settings, preparing it for publishing. As a result, CI steps testing and running on 0.64-stable branch can potentially fail due to missing dependencies.

Such case is publish-npm.js. There might be other errors too (that we haven't run into yet), because we do some development on release branches as well.

A better solution would be to not modify anything while doing bump-oss-versions.js (just bump them) and remove extraneous properties from package.json while preparing a package.

CC: @cpojer

[cpojer]

This fix looks good to me. I can’t merge it at fb this week (holidaaays!) but if you make the same PR against the release branch I can merge that for now, then merge this PR into master later.

[grabbou]

Thanks @cpojer, that was fast! It's okay for now, I am going to test it that we indeed remove package.json properties as designed and get back to you before we do the next RC (that's best moment to test it).

[cortinico]

Closing as we now moved to a proper monorepo and there is no need to cleanup package.json anymore