feat: make RCTBlobManager TurboModule-compatible - #35047
Conversation
Base commit: 48db6be |
Base commit: fd91748 |
|
PR build artifact for 1964d074acad3ebcdd7d391d4a303500a2ab92c7 is ready. |
|
PR build artifact for 1964d074acad3ebcdd7d391d4a303500a2ab92c7 is ready. |
|
@RSNara can you review this one? |
Done. Thanks. |
|
/rebase |
1964d07 to
6269a1e
Compare
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
PR build artifact for 6269a1e is ready. |
|
PR build artifact for 6269a1e is ready. |
|
This pull request was successfully merged by @andrestone in 279cfec. When will my fix make it into a release? | Upcoming Releases |
|
Hi! In the context of cutting the branch for 0.71.0-rc0, we had to revert this commit in #35188, for 2 reasons:
We will look into this thing before releasing 0.71 to make sure that the RCTBlobManager works properly! |
Summary: This diff reverts D40716048 (react@279cfec) (react#35047) which breaks RCTImageLoader. https://pxl.cl/2jKrM Those files are auto-generated and are not supposed to be edited manually. Changelog: [iOS] [Fixed] - react#35047 reverted. Reviewed By: cipolleschi Differential Revision: D40979350 fbshipit-source-id: ece2b9c653fe01e209a523e6a99e41a0605fddac
Summary: Pull Request resolved: #35188 This diff reverts D40716048 (279cfec) (#35047) which breaks RCTImageLoader. https://pxl.cl/2jKrM Those files are auto-generated and are not supposed to be edited manually. Changelog: [iOS] [Fixed] - #35047 reverted. Reviewed By: cipolleschi Differential Revision: D40979350 fbshipit-source-id: ef92cf05636cba818151d4184e0275a3aab56cff
Summary
Currently, RCTBlobManager (the native module for Blob support) cannot be loaded on iOS when the new architecture is enabled.
Changelog
[General] [Added] -
BlobModuletoRCTCoreModulesClassProviderTest Plan
The snippet below can be used to test Blob support with the new architecture enabled.
Related issue: #35042