Separate turbo and legacy module caches - #36986
Closed
RSNara wants to merge 2 commits into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45131296 |
Summary: tbd. nocommit Changelog: [Internal] Differential Revision: D45131297 fbshipit-source-id: 560831e096478c63c575598437d982fecfbb08da
Summary: Pull Request resolved: react#36986 global.nativeModuleProxy and global.__turboModuleProxy should not share the same cache. Otherwise, global.nativeModuleProxy could return TurboModules, and global.__turboModuleProxy could return legacy native modules. Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D45131296 fbshipit-source-id: 5456d31fc35d7eaac02298ea5a87b427c85b0c2d
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45131296 |
RSNara
force-pushed
the
export-D45131296
branch
from
April 20, 2023 17:19
5d1a698 to
e611ae8
Compare
Contributor
|
This pull request has been merged in 9637390. |
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Jul 29, 2026
…ct#36986) (react#57753) Summary: ## Summary Migrate internal `Libraries/` import subpaths from `react-native` to the incoming dedicated entry points in React Native 0.87. **Motivation** See [**RFC0894: Removing deep imports from react-native**](react-native-community/discussions-and-proposals#894) **Changes** The `react-private-interface` entry point has been created explicitly for the private contract between React ↔ React Native, and is 1:1 with the previous `ReactNativePrivateInterface` module. Both of the below `Libraries/` paths still exist, but are deprecated — this is a lagging migration that will enable cleanup in a future RN version. - `react-native/Libraries/Core/InitializeCore` → `react-native/setup-env` [react#57475](react#57475) - `react-native/Libraries/ReactPrivate/ReactNativePrivateInterface` → `react-native/react-private-interface` [react#57495](react#57495) ## Test Plan Flow DiffTrain build for [96fcba90138e9f1a73ee1cc4f79a653ec12fc3a9](react/react@96fcba9) Reviewed By: hoxyq Differential Revision: D113928305
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Jul 29, 2026
…ct#36986) (react#57753) Summary: ## Summary Migrate internal `Libraries/` import subpaths from `react-native` to the incoming dedicated entry points in React Native 0.87. **Motivation** See [**RFC0894: Removing deep imports from react-native**](react-native-community/discussions-and-proposals#894) **Changes** The `react-private-interface` entry point has been created explicitly for the private contract between React ↔ React Native, and is 1:1 with the previous `ReactNativePrivateInterface` module. Both of the below `Libraries/` paths still exist, but are deprecated — this is a lagging migration that will enable cleanup in a future RN version. - `react-native/Libraries/Core/InitializeCore` → `react-native/setup-env` [react#57475](react#57475) - `react-native/Libraries/ReactPrivate/ReactNativePrivateInterface` → `react-native/react-private-interface` [react#57495](react#57495) ## Test Plan Flow DiffTrain build for [96fcba90138e9f1a73ee1cc4f79a653ec12fc3a9](react/react@96fcba9) Reviewed By: hoxyq Differential Revision: D113928305
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Jul 29, 2026
…ct#36986) (react#57753) Summary: ## Summary Migrate internal `Libraries/` import subpaths from `react-native` to the incoming dedicated entry points in React Native 0.87. **Motivation** See [**RFC0894: Removing deep imports from react-native**](react-native-community/discussions-and-proposals#894) **Changes** The `react-private-interface` entry point has been created explicitly for the private contract between React ↔ React Native, and is 1:1 with the previous `ReactNativePrivateInterface` module. Both of the below `Libraries/` paths still exist, but are deprecated — this is a lagging migration that will enable cleanup in a future RN version. - `react-native/Libraries/Core/InitializeCore` → `react-native/setup-env` [react#57475](react#57475) - `react-native/Libraries/ReactPrivate/ReactNativePrivateInterface` → `react-native/react-private-interface` [react#57495](react#57495) ## Test Plan Flow DiffTrain build for [96fcba90138e9f1a73ee1cc4f79a653ec12fc3a9](react/react@96fcba9) Reviewed By: hoxyq Differential Revision: D113928305
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Jul 29, 2026
…ct#36986) (react#57753) Summary: ## Summary Migrate internal `Libraries/` import subpaths from `react-native` to the incoming dedicated entry points in React Native 0.87. **Motivation** See [**RFC0894: Removing deep imports from react-native**](react-native-community/discussions-and-proposals#894) **Changes** The `react-private-interface` entry point has been created explicitly for the private contract between React ↔ React Native, and is 1:1 with the previous `ReactNativePrivateInterface` module. Both of the below `Libraries/` paths still exist, but are deprecated — this is a lagging migration that will enable cleanup in a future RN version. - `react-native/Libraries/Core/InitializeCore` → `react-native/setup-env` [react#57475](react#57475) - `react-native/Libraries/ReactPrivate/ReactNativePrivateInterface` → `react-native/react-private-interface` [react#57495](react#57495) ## Test Plan Flow DiffTrain build for [96fcba90138e9f1a73ee1cc4f79a653ec12fc3a9](react/react@96fcba9) Reviewed By: hoxyq Differential Revision: D113928305
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Jul 29, 2026
…ct#36986) (react#57753) Summary: ## Summary Migrate internal `Libraries/` import subpaths from `react-native` to the incoming dedicated entry points in React Native 0.87. **Motivation** See [**RFC0894: Removing deep imports from react-native**](react-native-community/discussions-and-proposals#894) **Changes** The `react-private-interface` entry point has been created explicitly for the private contract between React ↔ React Native, and is 1:1 with the previous `ReactNativePrivateInterface` module. Both of the below `Libraries/` paths still exist, but are deprecated — this is a lagging migration that will enable cleanup in a future RN version. - `react-native/Libraries/Core/InitializeCore` → `react-native/setup-env` [react#57475](react#57475) - `react-native/Libraries/ReactPrivate/ReactNativePrivateInterface` → `react-native/react-private-interface` [react#57495](react#57495) ## Test Plan Flow DiffTrain build for [96fcba90138e9f1a73ee1cc4f79a653ec12fc3a9](react/react@96fcba9) Reviewed By: hoxyq Differential Revision: D113928305
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
global.nativeModuleProxy and global.__turboModuleProxy should not share the same cache.
Otherwise, global.nativeModuleProxy could return TurboModules, and global.__turboModuleProxy could return legacy native modules.
Changelog: [Internal]
Differential Revision: D45131296