Fix Android Image defaultSource runtime error

[mateoguzmana]

Summary:

Fixes #49075

The Image defaultSource prop is causing a runtime error from 0.77 just by using it in the Image component (see error in the linked issue). This might be a regression from some changes in the prop processing logic from either #47710, #47713 or #47754.

Changelog:

[ANDROID] [FIXED] - Fix Image defaultSource runtime error

Test Plan:

• Verify it doesn't throw any error on runtime anymore for Android.
• iOS behaviour should not be impacted as changes are Android specific

In the RNTester, you can use the following component:

import * as React from 'react';
import {Image, View} from 'react-native';

function Playground() {
  return (
    <View style={{flex: 1, justifyContent: 'center', alignItems: 'center'}}>
      <Image
        defaultSource={require('../../assets/bandaged.png')}
        source={{
          uri: 'https://i.natgeofe.com/n/548467d8-c5f1-4551-9f58-6817a8d2c45e/NationalGeographic_2572187_4x3.jpg',
        }}
        style={{width: 200, height: 200}}
      />
    </View>
  );
}

Also, this defaultSource prop is ignored in debug builds for Android (as per the docs) – but I've verified we get the defaultSource as a string, which is what we expect on the native side:

Screenshot of the Android logs

[dmytrorykun]

Accepting to address the regression. Will try to fix this forward during next several weeks.

[facebook-github-bot]

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@cortinico merged this pull request in 1c51b77.

[react-native-bot]

This pull request was successfully merged by @mateoguzmana in 1c51b77

^{When will my fix make it into a release? | How to file a pick request?}

[react-native-bot]

This pull request was successfully merged by @fbp93 in 7c50b5e

^{When will my fix make it into a release? | How to file a pick request?}

[react-native-bot]

This pull request was successfully merged by @mateoguzmana in 665212e

^{When will my fix make it into a release? | How to file a pick request?}