Add missing loadFromSource method in the DefaultRNFactoryDelegate#49931
Closed
cipolleschi wants to merge 1 commit into
Closed
Add missing loadFromSource method in the DefaultRNFactoryDelegate#49931cipolleschi wants to merge 1 commit into
cipolleschi wants to merge 1 commit into
Conversation
facebook-github-bot
added
CLA Signed
Summary: This change fixes the app startup in the Old Architecture by implementing the loadSourceForBridge:onProgress:onComplete method in the RCTDefaultReactNativeFactoryDelegate object. The method was missing here, so the Bridge was never trying to load the JS bundle from Metro, resulting in an empty app. ## Changelog: [iOS][Fixed] - Implement the loadSourceForBridge:onProgress:onComplete in the RCTDefaultReactNativeFactoryDelegate. Differential Revision: D70898811
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70898811 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70898811 |
cipolleschi
force-pushed
the
export-D70898811
branch
from
March 10, 2025 16:28
dbeb3bb to
2ca084d
Compare
Contributor
|
This pull request has been merged in 8b33668. |
Collaborator
|
This pull request was successfully merged by @cipolleschi in 8b33668 When will my fix make it into a release? | How to file a pick request? |
Saadnajmi
pushed a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Mar 24, 2025
…act#49931) Summary: Pull Request resolved: react#49931 This change fixes the app startup in the Old Architecture by implementing the loadSourceForBridge:onProgress:onComplete method in the RCTDefaultReactNativeFactoryDelegate object. The method was missing here, so the Bridge was never trying to load the JS bundle from Metro, resulting in an empty app. ## Changelog: [iOS][Fixed] - Implement the loadSourceForBridge:onProgress:onComplete in the RCTDefaultReactNativeFactoryDelegate. Reviewed By: cortinico Differential Revision: D70898811 fbshipit-source-id: 3e5d519a1965e92ace91ca6d5b316a9069279448
react-native-bot
pushed a commit
that referenced
this pull request
Apr 1, 2025
…9931) Summary: Pull Request resolved: #49931 This change fixes the app startup in the Old Architecture by implementing the loadSourceForBridge:onProgress:onComplete method in the RCTDefaultReactNativeFactoryDelegate object. The method was missing here, so the Bridge was never trying to load the JS bundle from Metro, resulting in an empty app. ## Changelog: [iOS][Fixed] - Implement the loadSourceForBridge:onProgress:onComplete in the RCTDefaultReactNativeFactoryDelegate. Reviewed By: cortinico Differential Revision: D70898811 fbshipit-source-id: 3e5d519a1965e92ace91ca6d5b316a9069279448
Collaborator
|
This pull request was successfully merged by @cipolleschi in 994ea3b When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This change fixes the app startup in the Old Architecture by implementing the loadSourceForBridge:onProgress:onComplete method in the RCTDefaultReactNativeFactoryDelegate object.
The method was missing here, so the Bridge was never trying to load the JS bundle from Metro, resulting in an empty app.
Changelog:
[iOS][Fixed] - Implement the loadSourceForBridge:onProgress:onComplete in the RCTDefaultReactNativeFactoryDelegate.
Differential Revision: D70898811