Fix broken Modal OSS E2E test due to createNewDialog setter - #52341
Closed
cortinico wants to merge 1 commit into
Closed
Fix broken Modal OSS E2E test due to createNewDialog setter#52341cortinico wants to merge 1 commit into
createNewDialog setter#52341cortinico wants to merge 1 commit into
Conversation
Summary: The setter for `createNewDialog` is now wrong (after D76834213). If the `createNewDialog` has been set to `true` by any other field, we should respect it and not set it to true/false regardless (only considering the `isEdgeToEdgeFeatureFlagOn`) property. This fixes it. Changelog: [Internal] [Changed] - Differential Revision: D77539533
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77539533 |
Contributor
|
This pull request has been merged in c4325c3. |
Collaborator
|
This pull request was successfully merged by @cortinico in c4325c3 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The setter for
createNewDialogis now wrong (after D76834213).If the
createNewDialoghas been set totrueby any other field, we should respect it and not set it to true/false regardless(only considering the
isEdgeToEdgeFeatureFlagOn) property.This fixes it.
Changelog:
[Internal] [Changed] -
Differential Revision: D77539533