Remove SampleTurboCxxModule example - #52442
Closed
christophpurrer wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77771111 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77771111 |
christophpurrer
force-pushed
the
export-D77771111
branch
from
July 4, 2025 18:10
b6a5138 to
fbd1018
Compare
Summary: Pull Request resolved: react#52442 Changelog: [Internal] The sample is from an outdated approach of enabling C++ Modules in RN which is not recommended anymore. Prefer C++ Turbo Modules if you need to expose / access C or C++ APIs in RN apps: https://reactnative.dev/docs/the-new-architecture/pure-cxx-modules It is not included in any RNTester app at this time Reviewed By: cortinico Differential Revision: D77771111
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77771111 |
christophpurrer
force-pushed
the
export-D77771111
branch
from
July 7, 2025 06:24
fbd1018 to
a3b6f9b
Compare
Contributor
|
This pull request has been merged in 0603455. |
Collaborator
|
This pull request was successfully merged by @christophpurrer in 0603455 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
The sample is from an outdated approach of enabling C++ Modules in RN which is not recommended anymore.
Prefer C++ Turbo Modules if you need to expose / access C or C++ APIs in RN apps:
https://reactnative.dev/docs/the-new-architecture/pure-cxx-modules
It is not included in any RNTester app at this time
Differential Revision: D77771111