Set displayName for Fantom configuration - #52778
Closed
rubennorte wants to merge 4 commits into
Closed
Conversation
Summary: Changelog: [internal] Reported locations for errors in Fantom is wrong, because it seems it's not ignoring "infra" frames. This was caused by the `stack` property in `ErrorWithCustomBlame` being set on the error objects and shadowing the getter that removes the necessary frames. This fixes that by forcing that property to be deleted. Reviewed By: christophpurrer Differential Revision: D78747119
…ode (#52759) Summary: Changelog: [internal] This introduces a new environment variable for Fantom to disable benchmarks (`FANTOM_FORCE_TEST_MODE`), without having to run in CI mode. Reviewed By: rshest Differential Revision: D78672864
Summary: Changelog: [internal] `FANTOM_FORCE_CI_MODE` is just an explicit way to indicate that we're on CI, so we'd run benchmarks in test mode, for example. `FANTOM_DEBUG_CPP` is just an alias for `FANTOM_ENABLE_CPP_DEBUGGING` which is unnecessarily long. Differential Revision: D78801918
Summary: Changelog: [internal] Jest has an option to select a specific project when running tests: ``` jest --selectProjects fantom ``` But for this to work, a `displayName` option needs to be set in the project configuration. This adds that for Fantom tests (using `fantom`). Differential Revision: D78802516
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78802516 |
Contributor
|
This pull request has been merged in fec6a0a. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
Jest has an option to select a specific project when running tests:
But for this to work, a
displayNameoption needs to be set in the project configuration. This adds that for Fantom tests (usingfantom).Differential Revision: D78802516