Fixing CLI to pass "sourcemap-output" option to bundler.#5288
Closed
skevy wants to merge 1 commit into
Closed
Conversation
Contributor
|
By analyzing the blame information on this pull request, we identified @davidaurelio, @sebmarkbage and @none to be potential reviewers. |
facebook-github-bot
added
GH Review: review-needed
CLA Signed
Contributor
Author
|
@facebook-github-bot shipit |
Contributor
Author
|
@facebook-github-bot shipit |
Contributor
|
Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/1532389727054788/int_phab to review. |
ghost
closed this
in
csudanthi
pushed a commit
to healthiqeng/react-native
that referenced
this pull request
Jan 16, 2016
Summary: Currently, the CLI is not passing the sourceMapURL option to the bundler, so source maps are output as "null". Closes react#5288 Reviewed By: svcscm Differential Revision: D2828092 Pulled By: androidtrunkagent fb-gh-sync-id: 2e464ddf65f0d4fcbff3c50281391cb30b5c799c
mkonicek
pushed a commit
that referenced
this pull request
Jan 18, 2016
Summary: Currently, the CLI is not passing the sourceMapURL option to the bundler, so source maps are output as "null". Closes #5288 Reviewed By: svcscm Differential Revision: D2828092 Pulled By: androidtrunkagent fb-gh-sync-id: 2e464ddf65f0d4fcbff3c50281391cb30b5c799c
grabbou
pushed a commit
to react-native-community/cli
that referenced
this pull request
Sep 26, 2018
Summary: Currently, the CLI is not passing the sourceMapURL option to the bundler, so source maps are output as "null". Closes react/react-native#5288 Reviewed By: svcscm Differential Revision: D2828092 Pulled By: androidtrunkagent fb-gh-sync-id: 2e464ddf65f0d4fcbff3c50281391cb30b5c799c
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the CLI is not passing the sourceMapURL option to the bundler, so source maps are output as "null".