Fix HEADER_SEARCH_PATHS for RuntimeExecutor when USE_FRAMEWORKS is enabled - #53099
Fix HEADER_SEARCH_PATHS for RuntimeExecutor when USE_FRAMEWORKS is enabled#53099sharifhh wants to merge 4 commits into
Conversation
|
Hi @sharifhh! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
cipolleschi
left a comment
There was a problem hiding this comment.
thanks for fixing this.
We should also update the install_modules_dependencies function. Can you take care of that?
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this in D79796637. |
|
@cipolleschi done, I also added it to codegen template, let me do a quick run of checks to see where we do this also. |
|
I guess that's it, no other places |
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this in D79796637. |
|
@cipolleschi should I do anything about tests snapshots? |
|
I updated the tests snapshots 🙏 |
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this in D79796637. |
|
@cipolleschi merged this pull request in dacd8f2. |
|
This pull request was successfully merged by @sharifhh in dacd8f2 When will my fix make it into a release? | How to file a pick request? |
|
why this commit wasn't part of 81 release? |
|
because the commit landed after we cut the branch for 0.81. I created it here: reactwg/react-native-releases#1093 0.81.1 should arrive next week, probably |
…abled (#53099) Summary: `#include <ReactCommon/RuntimeExecutor.h>` stopped working in react-native 0.81 when using frameworks because it is not part of ReactCommon anymore when the split happened for iOS. to fix this I am including RuntimeExecutor in search headers same way we include ReactCommon. ## Changelog: [IOS] [FIXED] - Fix import RuntimeExecutor.h with USE_FRAMEWORKS Pull Request resolved: #53099 Test Plan: You can enable USE_FRAMEWORKS and do `#include <react/renderer/uimanager/UIManager.h>` (which react-native-reanimated is doing). Build will fail complaining that it can't find ReactCommon/RuntimeExecutor.h which is included in UIManager.h Add my patch, it will work and build successfully Reviewed By: cortinico Differential Revision: D79796637 Pulled By: cipolleschi fbshipit-source-id: f8bb669cfb9f4414653655ed98d2cc6bb431a3e5
|
This pull request was successfully merged by @sharifhh in 4c781e4 When will my fix make it into a release? | How to file a pick request? |
Summary:
#include <ReactCommon/RuntimeExecutor.h>stopped working in react-native 0.81 when using frameworks because it is not part of ReactCommon anymore when the split happened for iOS.to fix this I am including RuntimeExecutor in search headers same way we include ReactCommon.
Changelog:
[IOS] [FIXED] - Fix import RuntimeExecutor.h with USE_FRAMEWORKS
Test Plan:
You can enable USE_FRAMEWORKS and do
#include <react/renderer/uimanager/UIManager.h>(which react-native-reanimated is doing).Build will fail complaining that it can't find ReactCommon/RuntimeExecutor.h which is included in UIManager.h
Add my patch, it will work and build successfully