Skip to content

Fix HEADER_SEARCH_PATHS for RuntimeExecutor when USE_FRAMEWORKS is enabled - #53099

Closed
sharifhh wants to merge 4 commits into
react:mainfrom
sharifhh:patch-1
Closed

Fix HEADER_SEARCH_PATHS for RuntimeExecutor when USE_FRAMEWORKS is enabled#53099
sharifhh wants to merge 4 commits into
react:mainfrom
sharifhh:patch-1

Conversation

@sharifhh

@sharifhh sharifhh commented Aug 6, 2025

Copy link
Copy Markdown
Contributor

Summary:

#include <ReactCommon/RuntimeExecutor.h> stopped working in react-native 0.81 when using frameworks because it is not part of ReactCommon anymore when the split happened for iOS.

to fix this I am including RuntimeExecutor in search headers same way we include ReactCommon.

Changelog:

[IOS] [FIXED] - Fix import RuntimeExecutor.h with USE_FRAMEWORKS

Test Plan:

You can enable USE_FRAMEWORKS and do #include <react/renderer/uimanager/UIManager.h> (which react-native-reanimated is doing).
Build will fail complaining that it can't find ReactCommon/RuntimeExecutor.h which is included in UIManager.h
Add my patch, it will work and build successfully

@meta-cla

meta-cla Bot commented Aug 6, 2025

Copy link
Copy Markdown

Hi @sharifhh!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 6, 2025
@meta-cla

meta-cla Bot commented Aug 6, 2025

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Aug 6, 2025
@sharifhh sharifhh changed the title Update utils.rb Fix HEADER_SEARCH_PATHS for RuntimeExecutor when USE_FRAMEWORKS is enabled Aug 6, 2025

@cipolleschi cipolleschi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing this.
We should also update the install_modules_dependencies function. Can you take care of that?

@facebook-github-bot

Copy link
Copy Markdown
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this in D79796637.

@sharifhh

sharifhh commented Aug 7, 2025

Copy link
Copy Markdown
Contributor Author

@cipolleschi done, I also added it to codegen template, let me do a quick run of checks to see where we do this also.

@sharifhh

sharifhh commented Aug 7, 2025

Copy link
Copy Markdown
Contributor Author

I guess that's it, no other places

@sharifhh
sharifhh requested a review from cipolleschi August 7, 2025 09:21
@facebook-github-bot

Copy link
Copy Markdown
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this in D79796637.

@sharifhh

sharifhh commented Aug 7, 2025

Copy link
Copy Markdown
Contributor Author

@cipolleschi should I do anything about tests snapshots?

@sharifhh

sharifhh commented Aug 7, 2025

Copy link
Copy Markdown
Contributor Author

I updated the tests snapshots 🙏

@facebook-github-bot

Copy link
Copy Markdown
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this in D79796637.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Aug 7, 2025
@facebook-github-bot

Copy link
Copy Markdown
Contributor

@cipolleschi merged this pull request in dacd8f2.

@react-native-bot

Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @sharifhh in dacd8f2

When will my fix make it into a release? | How to file a pick request?

@sharifhh

Copy link
Copy Markdown
Contributor Author

why this commit wasn't part of 81 release?
81 is not usable in current state when people use frameworks
any timeline for releasing this as a hotfix?

@cipolleschi

Copy link
Copy Markdown
Contributor

because the commit landed after we cut the branch for 0.81.
To pick this commit into the release, we need to create a pick request.

I created it here: reactwg/react-native-releases#1093

0.81.1 should arrive next week, probably

react-native-bot pushed a commit that referenced this pull request Aug 27, 2025
…abled (#53099)

Summary:
`#include <ReactCommon/RuntimeExecutor.h>` stopped working in react-native 0.81 when using frameworks because it is not part of ReactCommon anymore when the split happened for iOS.

to fix this I am including RuntimeExecutor in search headers same way we include ReactCommon.

## Changelog:

[IOS] [FIXED] - Fix import RuntimeExecutor.h with USE_FRAMEWORKS

Pull Request resolved: #53099

Test Plan:
You can enable USE_FRAMEWORKS and do `#include <react/renderer/uimanager/UIManager.h>` (which react-native-reanimated is doing).
Build will fail complaining that it can't find ReactCommon/RuntimeExecutor.h which is included in UIManager.h
Add my patch, it will work and build successfully

Reviewed By: cortinico

Differential Revision: D79796637

Pulled By: cipolleschi

fbshipit-source-id: f8bb669cfb9f4414653655ed98d2cc6bb431a3e5
@react-native-bot

Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @sharifhh in 4c781e4

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants