Skip to content

Android: Image Prefetching send ImageResizeMode as enum value#53516

Closed
christophpurrer wants to merge 3 commits into
react:mainfrom
christophpurrer:export-D81252246
Closed

Android: Image Prefetching send ImageResizeMode as enum value#53516
christophpurrer wants to merge 3 commits into
react:mainfrom
christophpurrer:export-D81252246

Conversation

@christophpurrer

Copy link
Copy Markdown
Contributor

Summary:
Changelog: [Internal]

Idea: Reduce JNI payload by sending int values instead of strings

Differential Revision: D81252246

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 28, 2025
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D81252246

@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D81252246

@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D81252246

@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D81252246

Summary:

Changelog: [Internal]

Don't prefetch local images shipped with the app

Reviewed By: lenaic

Differential Revision: D81200872
Summary:

Changelog: [Internal]

Goal is to simplify code and to lower the JNI payload

- Send values as `int` instead of `Double` if they are converted to `int` on the Java side
- We only have 2 optional values - all others are mandatory

Reviewed By: lenaic

Differential Revision: D81202196
…53516)

Summary:

Changelog: [General][Breaking] Android: Image Prefetching send ImageResizeMode as enum value

Idea: Reduce JNI payload by sending int values instead of strings

Differential Revision: D81252246
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D81252246

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Aug 30, 2025
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request has been merged in e30f34e.

@react-native-bot

Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @christophpurrer in e30f34e

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants