Android: Image Prefetching send ImageResizeMode as enum value#53516
Closed
christophpurrer wants to merge 3 commits into
Closed
Android: Image Prefetching send ImageResizeMode as enum value#53516christophpurrer wants to merge 3 commits into
christophpurrer wants to merge 3 commits into
Conversation
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D81252246 |
0af2657 to
423e2f7
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D81252246 |
423e2f7 to
39ba01c
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D81252246 |
39ba01c to
bd238d0
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D81252246 |
bd238d0 to
e25e876
Compare
Summary: Changelog: [Internal] Don't prefetch local images shipped with the app Reviewed By: lenaic Differential Revision: D81200872
Summary: Changelog: [Internal] Goal is to simplify code and to lower the JNI payload - Send values as `int` instead of `Double` if they are converted to `int` on the Java side - We only have 2 optional values - all others are mandatory Reviewed By: lenaic Differential Revision: D81202196
…53516) Summary: Changelog: [General][Breaking] Android: Image Prefetching send ImageResizeMode as enum value Idea: Reduce JNI payload by sending int values instead of strings Differential Revision: D81252246
e25e876 to
345ca38
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D81252246 |
Contributor
|
This pull request has been merged in e30f34e. |
Collaborator
|
This pull request was successfully merged by @christophpurrer in e30f34e When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
Idea: Reduce JNI payload by sending int values instead of strings
Differential Revision: D81252246