Check value of the Hermes V1 flag instead of whether it's defined - #53637
Closed
j-piasecki wants to merge 1 commit into
Closed
Check value of the Hermes V1 flag instead of whether it's defined#53637j-piasecki wants to merge 1 commit into
j-piasecki wants to merge 1 commit into
Conversation
Summary: Changelog: [ANDROID][FIXED] - Check for the value of the HERMES_V1_ENABLED flag instead of whether it's defined Differential Revision: D81920483
meta-cla
Bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D81920483 |
Collaborator
|
This pull request was successfully merged by @j-piasecki in d0fb338 When will my fix make it into a release? | How to file a pick request? |
Contributor
|
This pull request has been merged in d0fb338. |
vzaidman
pushed a commit
that referenced
this pull request
Sep 15, 2025
* Check value of the Hermes V1 flag instead of whether it's defined (#53637) Summary: Pull Request resolved: #53637 Changelog: [ANDROID][FIXED] - Check for the value of the HERMES_V1_ENABLED flag instead of whether it's defined Reviewed By: cortinico Differential Revision: D81920483 fbshipit-source-id: 550ae9fd27f666affe102b1c5c3f51bde7b5923e * Read Hermes V1 opt-in flag from the app's properties (#53665) Summary: Pull Request resolved: #53665 Changelog: [ANDROID][FIXED] - Read the Hermes V1 opt-in flag from the apps properties when building from source Reviewed By: cortinico Differential Revision: D82018545 fbshipit-source-id: f3c6fdbac190f47b6bf6836105d9e0909d8b86ba * Use artifacts published from Hermes repository when using Hermes V1 (#53725) Summary: Pull Request resolved: #53725 Changelog: [GENERAL][CHANGED] - Changed the coordinates of hermes artifacts when using Hermes V1 Adds a new `version.properties` file to keep which hermes versions should be consumed from Maven once the versions of Hermes and React Native are decoupled. This diff only implements changes necessary for consuming Hermes V1, as we don't want to migrate everything quite yet (0.82). Reviewed By: cortinico Differential Revision: D82204203 fbshipit-source-id: d712257a73f7ba54612a55c1b312416376f28b56
Collaborator
|
This pull request was successfully merged by @j-piasecki in 4c53204 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Changelog: [ANDROID][FIXED] - Check for the value of the HERMES_V1_ENABLED flag instead of whether it's defined
Differential Revision: D81920483