Add RuntimeTargetDelegate::serializeStackTrace API - #54048
Closed
motiz88 wants to merge 1 commit into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
motiz88
force-pushed
the
export-D83754142
branch
from
October 3, 2025 11:12
6e062c5 to
b6a81a2
Compare
motiz88
force-pushed
the
export-D83754142
branch
from
October 7, 2025 19:06
b6a81a2 to
480bcac
Compare
motiz88
force-pushed
the
export-D83754142
branch
from
October 7, 2025 19:14
480bcac to
6f95be0
Compare
motiz88
force-pushed
the
export-D83754142
branch
from
October 8, 2025 10:57
6f95be0 to
74fe475
Compare
Summary: Changelog: [Internal] Adds an engine-agnostic mechanism for serialising a previously captured stack trace as a CDP [`Runtime.StackTrace`](https://cdpstatus.reactnative.dev/devtools-protocol/tot/Runtime#type-StackTrace). This complements the existing `RuntimeTargetDelegate::captureStackTrace` method, which returns an opaque, engine-specific representation of a stack trace. This can be used as a building block for implementing higher-level CDP message types like [`Network.Initiator`](https://cdpstatus.reactnative.dev/devtools-protocol/tot/Network#type-Initiator) within React Native, while keeping the underlying stack trace representation private to each engine. NOTE: This diff includes an implementation for Hermes that duplicates logic from the Hermes codebase. Further up the stack, I have diffs to replace this with a new API to be provided by Hermes. Reviewed By: huntie Differential Revision: D83754142
motiz88
force-pushed
the
export-D83754142
branch
from
October 8, 2025 11:14
74fe475 to
2f26e1d
Compare
|
This pull request has been merged in b31a2fb. |
Collaborator
|
This pull request was successfully merged by @motiz88 in b31a2fb When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
Adds an engine-agnostic mechanism for serialising a previously captured stack trace as a CDP
Runtime.StackTrace. This complements the existingRuntimeTargetDelegate::captureStackTracemethod, which returns an opaque, engine-specific representation of a stack trace.This can be used as a building block for implementing higher-level CDP message types like
Network.Initiatorwithin React Native, while keeping the underlying stack trace representation private to each engine.Differential Revision: D83754142