Allow overriding the horizontal scroll position restore - #54115
Closed
lenaic wants to merge 3 commits into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
added 3 commits
October 9, 2025 18:20
Summary: This diff adds the possibility to control the use of `Trait::Hidden` on Android platforms through feature flags. The feature flag is Android specific and only accessed on Android platforms. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D84289662
Summary: With `Trait::hidden` unmounting and remounting views for shadow nodes holding scroll state, we have to restore the scroll position from the shadow node state when the scroll view is being remounted Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D84291899
Summary: Horizontal scroll view extensions should be able to customize the scrolling behavior for state restores. This adds the `restoreScrollTo` function that will be called to restore the scroll position to the location provided by the shadow node state. Changelog: [Internal] Differential Revision: D84310601
lenaic
force-pushed
the
export-D84310601
branch
from
October 10, 2025 01:21
3caa162 to
0a37f89
Compare
|
This pull request has been merged in e926ad0. |
Collaborator
|
This pull request was successfully merged by Nick Lefever in e926ad0 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Horizontal scroll view extensions should be able to customize the scrolling behavior for state restores. This adds the
restoreScrollTofunction that will be called to restore the scroll position to the location provided by the shadow node state.Changelog: [Internal]
Differential Revision: D84310601