always invoke onRender via UIManagerNativeAnimatedDelegate#54211
Closed
zeyap wants to merge 1 commit into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
zeyap
force-pushed
the
export-D85071075
branch
3 times, most recently
from
dada95b to
8cf1353
Compare
Summary: ## Changelog: [Internal] [Added] - always invoke onRender via UIManagerNativeAnimatedDelegate Previously only android invokes `onRender` via UIManagerNativeAnimatedDelegate::runAnimationFrame() consolidating so it's easier for debugging, also in cases where we want to add extra work per frame (e.g. add performance logging) in AnimatedNodesManagerProvider Reviewed By: sammy-SC Differential Revision: D85071075
zeyap
force-pushed
the
export-D85071075
branch
2 times, most recently
from
cf799ab to
ff164ce
Compare
|
This pull request has been merged in 4c7351d. |
Collaborator
|
This pull request was successfully merged by @zeyap in 4c7351d When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
[Internal] [Added] - always invoke onRender via UIManagerNativeAnimatedDelegate
Previously only android invokes
onRendervia UIManagerNativeAnimatedDelegate::runAnimationFrame()consolidating so it's easier for debugging, also in cases where we want to add extra work per frame (e.g. add performance logging) in AnimatedNodesManagerProvider
Reviewed By: sammy-SC
Differential Revision: D85071075