[General][Fixed] Fixed test build breaks after CP https://github.com/google/googletest/commit/7d7e750850c65099e49cc1a1aac94a79a914bba7 - #55133
Closed
talbenesh wants to merge 1 commit into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@talbenesh has exported this pull request. If you are a Meta employee, you can view the originating Diff in D90514337. |
talbenesh
changed the title
talbenesh
force-pushed
the
export-D90514337
branch
from
January 12, 2026 19:10
3dc3c21 to
ad3ce69
Compare
Summary: ## Changelog: [General] [Fixed] - Fix test build breaks after GoogleTest update google/googletest@7d7e750 included a breaking change of changing GetWithoutMatchers() to WithoutMatchers::Get() (googletest/googlemock/include/gmock/internal/gmock-internal-utils.h) This caused build breaks for a few tests that weren't signaled in the original CP. This fixes it Reviewed By: joachimr2 Differential Revision: D90514337
talbenesh
force-pushed
the
export-D90514337
branch
from
January 12, 2026 19:15
ad3ce69 to
71e549c
Compare
Collaborator
|
This pull request was successfully merged by Tal Benesh in 2a776b1 When will my fix make it into a release? | How to file a pick request? |
|
This pull request has been merged in 2a776b1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
[General][Fixed] - Fixed test build breaks after GoogleTest update
google/googletest@7d7e750 included a breaking change of changing GetWithoutMatchers() to WithoutMatchers::Get() (googletest/googlemock/include/gmock/internal/gmock-internal-utils.h)
This caused build breaks for a few tests that weren't signaled in the original CP.
This fixes it
Reviewed By: joachimr2
Differential Revision: D90514337