Stub internals of Paper Text ShadowNodes#55438
Closed
NickGerleman wants to merge 1 commit into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@NickGerleman has exported this pull request. If you are a Meta employee, you can view the originating Diff in D92481655. |
NickGerleman
force-pushed
the
export-D92481655
branch
from
5a2b20b to
79d0dda
Compare
NickGerleman
force-pushed
the
export-D92481655
branch
from
79d0dda to
8656716
Compare
cortinico
approved these changes
Feb 6, 2026
cortinico
left a comment
cortinico
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
NickGerleman
force-pushed
the
export-D92481655
branch
from
8656716 to
949a632
Compare
NickGerleman
force-pushed
the
export-D92481655
branch
from
949a632 to
2366ef1
Compare
Summary: All of this is dead, but still uses the text infra by Fabric that we continue to change. Lets stub out the internals of the ShadowNodes, to make it easier to edit RN text internals, and shave some code/space. mdvacca or cortinico should be able to tell if this will cause issues with interop layer. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D92481655
NickGerleman
force-pushed
the
export-D92481655
branch
from
2366ef1 to
e5362f7
Compare
|
This pull request has been merged in 1259771. |
Collaborator
|
This pull request was successfully merged by @NickGerleman in 1259771 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
All of this is dead, but still uses the text infra by Fabric that we continue to change. Lets stub out the internals of the ShadowNodes, to make it easier to edit RN text internals, and shave some code/space.
mdvacca or cortinico should be able to tell if this will cause issues with interop layer.
Changelog: [Internal]
Differential Revision: D92481655