Fix visibility of DevSupportHttpClient by extracting DevSupportRequestHeaders#55739
Closed
cortinico wants to merge 1 commit into
Closed
Fix visibility of DevSupportHttpClient by extracting DevSupportRequestHeaders#55739cortinico wants to merge 1 commit into
cortinico wants to merge 1 commit into
Conversation
…tHeaders Summary: Extract header management from the `internal` `DevSupportHttpClient` into a new public `DevSupportRequestHeaders` singleton in `devsupport.interfaces`. This allows external consumers (e.g. Expo Dev Launcher) to register custom HTTP headers that will be applied to all React Native dev-support network traffic without depending on internal APIs. `DevSupportHttpClient` now delegates to `DevSupportRequestHeaders.allHeaders()` instead of maintaining its own `ConcurrentHashMap`. A separate `request_headers` Buck target is introduced to avoid a dependency cycle (`bridge` → `inspector` → `interfaces` → `bridge`). Changelog: [Android][Added] - Public DevSupportRequestHeaders API for registering custom dev-support HTTP headers Differential Revision: D94354168
|
@cortinico has exported this pull request. If you are a Meta employee, you can view the originating Diff in D94354168. |
meta-cla
Bot
added
the
CLA Signed
|
This pull request has been merged in e0d34b2. |
Collaborator
|
This pull request was successfully merged by @cortinico in e0d34b2 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Extract header management from the
internalDevSupportHttpClientinto a newpublic
DevSupportRequestHeaderssingleton indevsupport.interfaces. Thisallows external consumers (e.g. Expo Dev Launcher) to register custom HTTP
headers that will be applied to all React Native dev-support network traffic
without depending on internal APIs.
DevSupportHttpClientnow delegates toDevSupportRequestHeaders.allHeaders()instead of maintaining its own
ConcurrentHashMap.A separate
request_headersBuck target is introduced to avoid a dependencycycle (
bridge→inspector→interfaces→bridge).Changelog: [Android][Added] - Public DevSupportRequestHeaders API for registering custom dev-support HTTP headers
Differential Revision: D94354168