Extend check-packages-test to validate additional required fields (#57510)#57510
Closed
huntie wants to merge 2 commits into
Closed
Extend check-packages-test to validate additional required fields (#57510)#57510huntie wants to merge 2 commits into
huntie wants to merge 2 commits into
Conversation
Summary: Simplify/unify various mechanisms for the monorepo's package invariants. These checks were previously scattered: - `private/monorepo-tests` package (manifest field checks) - `.github/workflow-scripts/lint_files.sh` (`.npmignore` ban) - `react-native/eslint-plugin-monorepo` (manifest field checks — duplicated) This folds everything into `scripts/monorepo-tests/__tests__/check-packages-test.js`. A plain Jest test is the most extensible home for future checks. We also drop the `jsonc-eslint-parser` dependency. Changelog: [Internal] Differential Revision: D111471313
meta-cla
Bot
added
the
CLA Signed
|
@huntie has exported this pull request. If you are a Meta employee, you can view the originating Diff in D111471314. |
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Jul 10, 2026
…act#57510) Summary: Pull Request resolved: react#57510 Extend `check-packages-test.js` to catch two more classes of manifest drift: published packages missing required fields, and packages under `private/` missing the `private` flag. **Motivation** Inspired by react-native-community/template#241 — avoid a missing field blocking a future RN package publish. **Other changes** - To satisfy the new `files` requirement, add an explicit `files` allowlist to the four config packages that lacked one. As a side effect, this saves some `__tests__` files from being distributed. Changelog: [Internal] Differential Revision: D111471314
huntie
force-pushed
the
export-D111471314
branch
from
f401cbb to
e7a03b2
Compare
meta-codesync
Bot
changed the title
…act#57510) Summary: Pull Request resolved: react#57510 Extend `check-packages-test.js` to catch two more classes of manifest drift: published packages missing required fields, and packages under `private/` missing the `private` flag. **Motivation** Inspired by react-native-community/template#241 — avoid a missing field blocking a future RN package publish. **Other changes** - To satisfy the new `files` requirement, add an explicit `files` allowlist to the four config packages that lacked one. As a side effect, this saves some `__tests__` files from being distributed. Changelog: [Internal] Differential Revision: D111471314
huntie
force-pushed
the
export-D111471314
branch
from
e7a03b2 to
9a77d4b
Compare
cortinico
approved these changes
Jul 10, 2026
cortinico
left a comment
cortinico
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
|
This pull request has been merged in 042833e. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Extend
check-packages-test.jsto catch two more classes of manifest drift: published packages missing required fields, and packages underprivate/missing theprivateflag.Motivation
Inspired by react-native-community/template#241 — avoid a missing field blocking a future RN package publish.
Other changes
filesrequirement, add an explicitfilesallowlist to the four config packages that lacked one. As a side effect, this saves some__tests__files from being distributed.Changelog: [Internal]
Differential Revision: D111471314