Skip to content

Downgrade RCTStatusBarManager error to a warning under VC-based status bar (#57631) #57631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shwanton wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −4
Open

Downgrade RCTStatusBarManager error to a warning under VC-based status bar (#57631) #57631

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/react-native/React/CoreModules/RCTStatusBarManager.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,8 +148,8 @@ - (void)applicationWillChangeStatusBarFrame:(NSNotification *)notification
dispatch_async(dispatch_get_main_queue(), ^{
UIStatusBarStyle statusBarStyle = [RCTConvert UIStatusBarStyle:style];
if (RCTViewControllerBasedStatusBarAppearance()) {
RCTLogError(@"RCTStatusBarManager module requires that the \
UIViewControllerBasedStatusBarAppearance key in the Info.plist is set to NO");
RCTLogWarn(@"RCTStatusBarManager is a no-op when \
UIViewControllerBasedStatusBarAppearance is YES; set the status bar from your view controller instead");
} else {
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wdeprecated-declarations"
Expand All @@ -164,8 +164,8 @@ - (void)applicationWillChangeStatusBarFrame:(NSNotification *)notification
dispatch_async(dispatch_get_main_queue(), ^{
UIStatusBarAnimation animation = [RCTConvert UIStatusBarAnimation:withAnimation];
if (RCTViewControllerBasedStatusBarAppearance()) {
RCTLogError(@"RCTStatusBarManager module requires that the \
UIViewControllerBasedStatusBarAppearance key in the Info.plist is set to NO");
RCTLogWarn(@"RCTStatusBarManager is a no-op when \
UIViewControllerBasedStatusBarAppearance is YES; set the status bar from your view controller instead");
} else {
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wdeprecated-declarations"
Expand Down
Loading