Skip to content

fix: remove dead promise polyfill import from polyfillPromise.js #57807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stareezy-1 wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −17
Open

fix: remove dead promise polyfill import from polyfillPromise.js #57807

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 10 additions & 17 deletions packages/react-native/Libraries/Core/polyfillPromise.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,29 +10,22 @@

'use strict';

const {polyfillGlobal} = require('../Utilities/PolyfillFunctions');

/**
* Set up Promise. The native Promise implementation throws the following error:
* ERROR: Event loop not supported.
* Set up Promise. Hermes provides a native Promise implementation that
* satisfies all requirements of React Native.
*
* If you don't need these polyfills, don't use InitializeCore; just directly
* require the modules you need from InitializeCore for setup.
*/

// If global.Promise is provided by Hermes, we are confident that it can provide
// all the methods needed by React Native, so we can directly use it.
if (global?.HermesInternal?.hasPromise?.()) {
const HermesPromise = global.Promise;
// Hermes is the only supported JS engine and always provides Promise natively.
const HermesPromise = global.Promise;

if (__DEV__) {
if (typeof HermesPromise !== 'function') {
console.error('HermesPromise does not exist');
}
global.HermesInternal?.enablePromiseRejectionTracker?.(
require('../promiseRejectionTrackingOptions').default,
);
if (__DEV__) {
if (typeof HermesPromise !== 'function') {
console.error('HermesPromise does not exist');
}
} else {
polyfillGlobal('Promise', () => require('../Promise').default);
global.HermesInternal?.enablePromiseRejectionTracker?.(
require('../promiseRejectionTrackingOptions').default,
);
}