Reproducer for #57836: Fabric dynamic border/outline colors resolve against the system appearance - #57838
Closed
JacquesLeupin wants to merge 1 commit into
Closed
Conversation
…nst the system appearance
Author
|
Moving the reproducer to a fork branch per our workflow — runnable single-file reproducer lives at https://github.com/JacquesLeupin/react-native/tree/repro/fabric-border-trait-collection-57836 (diff: main...JacquesLeupin:react-native:repro/fabric-border-trait-collection-57836), linked from #57836. |
|
Warning Missing Test Plan Please add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Runnable reproducer for #57836 — on Fabric,
borderColor/outlineColorset from a dynamic color (PlatformColor/DynamicColorIOS) resolve against the system appearance and ignoreoverrideUserInterfaceStyle. Edits onlyRNTesterPlayground.js; not intended to be merged.How to run
Appearance.setColorScheme('dark')at 2s and mounts a second row of boxes at 4s; a button resets to the system scheme and re-runs.One
DynamicColorIOS({light: red, dark: green})feeds every fill and border; the two bordered boxes cover both border code paths (border-image, and CoreAnimationlayer.borderColorviaoverflow: 'hidden').Expected: once
useColorScheme()reportsdark, every fill and border is green.Actual: fills turn green, but row A's borders (mounted before the override) stay red — the light variant — on both border paths, and persist indefinitely. Freshly-created views in row B can heal via the attach-time trait change; recycled views in real apps reattach with unchanged traits and stick like row A.
Fix proposed in #57837.
Changelog
[INTERNAL] - Reproducer for #57836, not for merge