xplat/js/react-native-github/packages/react-native/Libraries/Blob/RCTFileReaderModule.mm (#57847) - #57847
Open
christophpurrer wants to merge 1 commit into
Open
xplat/js/react-native-github/packages/react-native/Libraries/Blob/RCTFileReaderModule.mm (#57847)#57847christophpurrer wants to merge 1 commit into
christophpurrer wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@christophpurrer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D115001596. |
meta-codesync
Bot
changed the title
christophpurrer
force-pushed
the
export-D115001596
branch
from
August 7, 2026 14:12
aafdcf5 to
24e894a
Compare
christophpurrer
pushed a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Aug 7, 2026
…FileReaderModule.mm (react#57847) Summary: ...build_codegen_spec built the RCTBlobApple target and I read the generated `protocol NativeFileReaderModuleSpec` from FBReactNativeSpec.h; (2) apply_cast_mod mechanically rewrote both async methods — no FLAG lines emitted; (3) buck_build_verify succeeded; (4) Lint reported no issues. _____ * Do **NOT** post in the CodemodService Feedback group about this specific diff. * If you have feedback, comment on the diff and use an appropriate diff action. This [diff was created](https://www.internalfb.com/intern/sandcastle/job/31525200232184606/) with [CodemodService](https://www.internalfb.com/codemod_service/CodemodConfigDevmateDropRctExportMethod). Reviewed By: christophpurrer Differential Revision: D115001596
…FileReaderModule.mm (react#57847) Summary: ...build_codegen_spec built the RCTBlobApple target and I read the generated `protocol NativeFileReaderModuleSpec` from FBReactNativeSpec.h; (2) apply_cast_mod mechanically rewrote both async methods — no FLAG lines emitted; (3) buck_build_verify succeeded; (4) Lint reported no issues. _____ * Do **NOT** post in the CodemodService Feedback group about this specific diff. * If you have feedback, comment on the diff and use an appropriate diff action. This [diff was created](https://www.internalfb.com/intern/sandcastle/job/31525200232184606/) with [CodemodService](https://www.internalfb.com/codemod_service/CodemodConfigDevmateDropRctExportMethod). Reviewed By: christophpurrer Differential Revision: D115001596
christophpurrer
force-pushed
the
export-D115001596
branch
from
August 7, 2026 14:14
24e894a to
35e4aab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
...build_codegen_spec built the RCTBlobApple target and I read the generated
protocol NativeFileReaderModuleSpecfrom FBReactNativeSpec.h; (2) apply_cast_mod mechanically rewrote both async methods — no FLAG lines emitted; (3) buck_build_verify succeeded; (4) Lint reported no issues.This diff was created with CodemodService.
Reviewed By: christophpurrer
Differential Revision: D115001596