Cover react/renderer/dom with Stable API guards (#57961) - #57961
Closed
j-piasecki wants to merge 1 commit into
Closed
Cover react/renderer/dom with Stable API guards (#57961)#57961j-piasecki wants to merge 1 commit into
react/renderer/dom with Stable API guards (#57961)#57961j-piasecki wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Software Mansion
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D116013879. |
meta-codesync
Bot
changed the title
react/renderer/dom with Stable API guardsreact/renderer/dom with Stable API guards (#57961)
j-piasecki
force-pushed
the
export-D116013879
branch
from
August 18, 2026 11:08
790f0da to
82c13a3
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Aug 18, 2026
Summary: Classifies `react/renderer/dom` as a private target under the three-tier C++ stable API visibility model. `DOM.h` now includes `<react/cxxstableapi/PrivateGuard.h>`. Consumers that opt into `RN_STRICT_API` now get an error if they include `DOM.h` directly; without that flag the guard is inert, so no existing build changes behaviour. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D116013879
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Aug 19, 2026
Summary: Classifies `react/renderer/dom` as a private target under the three-tier C++ stable API visibility model. `DOM.h` now includes `<react/cxxstableapi/PrivateGuard.h>`. Consumers that opt into `RN_STRICT_API` now get an error if they include `DOM.h` directly; without that flag the guard is inert, so no existing build changes behaviour. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D116013879
j-piasecki
force-pushed
the
export-D116013879
branch
from
August 19, 2026 07:59
82c13a3 to
1fd8470
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Aug 20, 2026
Summary: Classifies `react/renderer/dom` as a private target under the three-tier C++ stable API visibility model. `DOM.h` now includes `<react/cxxstableapi/PrivateGuard.h>`. Consumers that opt into `RN_STRICT_API` now get an error if they include `DOM.h` directly; without that flag the guard is inert, so no existing build changes behaviour. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D116013879
j-piasecki
force-pushed
the
export-D116013879
branch
from
August 20, 2026 06:06
1fd8470 to
d86f70e
Compare
Summary: Classifies `react/renderer/dom` as a private target under the three-tier C++ stable API visibility model. `DOM.h` now includes `<react/cxxstableapi/PrivateGuard.h>`. Consumers that opt into `RN_STRICT_API` now get an error if they include `DOM.h` directly; without that flag the guard is inert, so no existing build changes behaviour. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D116013879
j-piasecki
force-pushed
the
export-D116013879
branch
from
August 20, 2026 06:07
d86f70e to
ff165a6
Compare
|
This pull request has been merged in 6e41084. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Classifies
react/renderer/domas a private target under the three-tier C++ stable API visibility model.DOM.hnow includes<react/cxxstableapi/PrivateGuard.h>. Consumers that opt intoRN_STRICT_APInow get an error if they includeDOM.hdirectly; without that flag the guard is inert, so no existing build changes behaviour.Changelog: [Internal]
Reviewed By: cipolleschi
Differential Revision: D116013879