feat(android) - url function support in backgroundImage - #58247
Draft
intergalacticspacehighway wants to merge 1 commit into
Draft
feat(android) - url function support in backgroundImage#58247intergalacticspacehighway wants to merge 1 commit into
url function support in backgroundImage#58247intergalacticspacehighway wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
This was referenced Aug 30, 2026
intergalacticspacehighway
marked this pull request as draft
August 30, 2026 13:05
copy bitmap on background thread
intergalacticspacehighway
force-pushed
the
background-image-url-android
branch
from
August 30, 2026 13:09
455c994 to
cc0de3f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
urlsyntax. e.g.backgroundImage: url("https://example.com/1.png").urlfunction support inbackgroundImage#58246 (JS/parser) and feat(iOS) -urlfunction support inbackgroundImage#58248 (iOS) into this one.How:
Uses Fresco's image pipeline to fetch the image in
BackgroundImageURLLoader. Copies the bitmap from the fetched resource and draws it in theBackgroundDrawablecanvas usingdrawBitmap.Changelog:
[ANDROID] [ADDED] -
urlsupport withbackgroundImageTest Plan:
urlfunction support inbackgroundImage#58246, this PR and feat(iOS) -urlfunction support inbackgroundImage#58248, then test the example added in the JS PR.urlsyntax in JS and native parser.:packages:react-native:ReactAndroid:compileDebugKotlinsucceeds;ktfmtCheckis clean.