Upgrade Text visibility to "for frameworks" (#58284) - #58284
Closed
j-piasecki wants to merge 2 commits into
Closed
Conversation
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D118440348. |
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Sep 3, 2026
Summary: Pull Request resolved: react#58284 Reclassifies `react/renderer/components/text:text` from public to "for frameworks" under the C++ stable API three-tier visibility model. Consumers that opt into `RN_STRICT_API` now get a suppressible warning where they previously got an error pointing at the umbrella, and can acknowledge it with `RN_ALLOW_FRAMEWORKS`; without that flag the guards are inert, so no existing build changes behaviour. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D118440348
j-piasecki
force-pushed
the
export-D118440348
branch
from
September 3, 2026 07:55
d07f485 to
d064ec2
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Sep 3, 2026
Summary: Pull Request resolved: react#58284 Reclassifies `react/renderer/components/text:text` from public to "for frameworks" under the C++ stable API three-tier visibility model. Consumers that opt into `RN_STRICT_API` now get a suppressible warning where they previously got an error pointing at the umbrella, and can acknowledge it with `RN_ALLOW_FRAMEWORKS`; without that flag the guards are inert, so no existing build changes behaviour. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D118440348
j-piasecki
force-pushed
the
export-D118440348
branch
from
September 3, 2026 08:01
d064ec2 to
09ae14a
Compare
Summary: Reclassifies `react/renderer/components/modal:modal` from public to "for frameworks" under the C++ stable API three-tier visibility model. Consumers that opt into `RN_STRICT_API` now get a suppressible warning where they previously got an error pointing at the umbrella, and can acknowledge it with `RN_ALLOW_FRAMEWORKS`; without that flag the guards are inert, so no existing build changes behaviour. Changelog: [Internal] Differential Revision: D118440328
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Sep 3, 2026
Summary: Pull Request resolved: react#58284 Reclassifies `react/renderer/components/text:text` from public to "for frameworks" under the C++ stable API three-tier visibility model. Consumers that opt into `RN_STRICT_API` now get a suppressible warning where they previously got an error pointing at the umbrella, and can acknowledge it with `RN_ALLOW_FRAMEWORKS`; without that flag the guards are inert, so no existing build changes behaviour. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D118440348
j-piasecki
force-pushed
the
export-D118440348
branch
from
September 3, 2026 08:07
09ae14a to
585b93e
Compare
Summary: Pull Request resolved: react#58284 Reclassifies `react/renderer/components/text:text` from public to "for frameworks" under the C++ stable API three-tier visibility model. Consumers that opt into `RN_STRICT_API` now get a suppressible warning where they previously got an error pointing at the umbrella, and can acknowledge it with `RN_ALLOW_FRAMEWORKS`; without that flag the guards are inert, so no existing build changes behaviour. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D118440348
j-piasecki
force-pushed
the
export-D118440348
branch
from
September 3, 2026 08:13
585b93e to
13df16c
Compare
|
This pull request has been merged in 02cb3ca. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Reclassifies
react/renderer/components/text:textfrom public to "for frameworks" under the C++ stable API three-tier visibility model.Consumers that opt into
RN_STRICT_APInow get a suppressible warning where they previously got an error pointing at the umbrella, and can acknowledge it withRN_ALLOW_FRAMEWORKS; without that flag the guards are inert, so no existing build changes behaviour.Changelog: [Internal]
Reviewed By: christophpurrer
Differential Revision: D118440348